9212 chain helpers #9439
Merged
9212 chain helpers #9439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
19bc874
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dac32715.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9212-chain-helpers.agoric-sdk.pages.dev |
Merged
turadg
force-pushed
the
9212-chain-helpers
branch
from
e1f08bb
to
d6390e4
Compare
dckc
reviewed
Jun 4, 2024
dckc
reviewed
Jun 4, 2024
dckc
reviewed
Jun 4, 2024
dckc
reviewed
Jun 4, 2024
dckc
reviewed
Jun 4, 2024
dckc
reviewed
Jun 4, 2024
mergify bot
added a commit
that referenced
this pull request
Jun 4, 2024
refs: #9212 ## Description #9439 needs some of the fakes in the network tests. This wraps them up a bit for re-use elsewhere. ### Security Considerations n/a, test code <!-- Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls? --> ### Scaling Considerations n/a, test code <!-- Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated? --> ### Documentation Considerations API docs may show these ### Testing Considerations per se ### Upgrade Considerations n/a, test code
turadg
force-pushed
the
9212-chain-helpers
branch
from
d6390e4
to
454f184
Compare
dckc
approved these changes
Jun 4, 2024
| }, | ||
| }); | ||
|
|
||
| // TODO find a way to wait until completionTime, so we can check the count has gone back down |
There was a problem hiding this comment.
We can query and then wait like we do for blocks etc.
It's 21 days, so we probably want to reduce it to something like 15sec first.
$ agd query staking params -o json | jq .unbonding_time
"1814400s"
packages/orchestration/src/facade.js
Outdated
| const addressStr = await E(account).getAddress(); | ||
| return { | ||
| address: addressStr, | ||
| chainId: 'agoric-3', |
There was a problem hiding this comment.
chainId will be agoriclocal in a3p, right? seems like chainId should be passed in. Or a TODO or something.
Comment on lines
+64
to
+70
| send(toAccount, amount) { | ||
| // FIXME implement | ||
| console.log('send got', toAccount, amount); | ||
| }, |
There was a problem hiding this comment.
local-chain-account-kit implements send(), right? are we not ready to wire it up?
There was a problem hiding this comment.
To know it's covered I've been leaning to writing a breaking test first and then implementing until green
Comment on lines
+64
to
+65
| await t.throwsAsync(E(account).getBalances(), { | ||
| message: 'not yet implemented', |
There was a problem hiding this comment.
I suppose this has an implicit TODO
turadg
force-pushed
the
9212-chain-helpers
branch
from
454f184
to
e0e2a82
Compare
dckc
approved these changes
Jun 4, 2024
turadg
force-pushed
the
9212-chain-helpers
branch
from
e0e2a82
to
ab9e449
Compare
0xpatrickdev
reviewed
Jun 4, 2024
Comment on lines
141
to
143
| console.error( | ||
| 'FIXME deposit noop until https://github.com/Agoric/agoric-sdk/issues/9193', | ||
| ); |
There was a problem hiding this comment.
I don't think we'll have deposit or getPurse with 9193. The plan is to demonstrate how to use a LocalChainAccount to deposit (and transfer) ERTP assets to a ChainAccount.
0xpatrickdev
approved these changes
Jun 4, 2024
| portAllocator, | ||
| protocol, | ||
| when, | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9212
Description
Incremental progress on #9212
Plus some drive-by improvements
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations