network test tools #9440
Merged
network test tools #9440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
65b0840
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29bdb3f2.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-network-tools.agoric-sdk.pages.dev |
|
second thought, maybe it would be better to copy these fake utils over to the other package so |
Merged
iomekam
approved these changes
Jun 4, 2024
|
|
||
| return { | ||
| makeEchoConnectionHandler, | ||
| makeVowKit, |
There was a problem hiding this comment.
Maybe it makes sense to return power here? This will also make it easier to leverage watch if we need it in the tests
There was a problem hiding this comment.
I figured when it's needed it can be added. This is just test code so it's easy and quick to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9212
Description
#9439 needs some of the fakes in the network tests. This wraps them up a bit for re-use elsewhere.
Security Considerations
n/a, test code
Scaling Considerations
n/a, test code
Documentation Considerations
API docs may show these
Testing Considerations
per se
Upgrade Considerations
n/a, test code