Upgrade-16 cherry-picks round 2 #9625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem ``` Error [ERR_MODULE_NOT_FOUND]: Cannot find module '.../node_modules/@agoric/vow/vat.js' imported from .../contract/test/test-contract.js ``` ### Testing Considerations This manual test passes with this PR but fails without it: ```console ~/projects/agoric-sdk/packages/vow$ yarn pack ~/projects/agoric-sdk/packages/vow$ tar tf *.tgz |grep vat package/vat.js ```
closes: #9600 ## Description Check that an explicit height matches the latest height as exporting historical height is not supported by swing-store ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations Release notes should make clear limits of new support ### Testing Considerations Manually tested explicit height ### Upgrade Considerations Would be good to include in u16 if we cut a new rc1
closes: #9614 closes: #7012 refs: agoric-labs/xsnap-pub#49 ## Description Wire a mechanism to force rebuilds of xsnap when some build environments change, or if the xsnap binary is found to be out of date through the embedded xsnap package version. Moves the `agd build` check to depend on a version check implemented by the xsnap package, which now only depends on the package version that is dynamically inserted instead of an explicit magic string that wasn't getting updated. #7012 (comment) expressed concerns with relying on the xsnap package version, however: - any changes to `xsnap-pub` or `moddable` submodules would result in a change to the checked in `build.env` file, which would be detected by `lerna` during the publish process. While a version bump would not apply for contributors of the sdk (aka not every xsnap change results in a version change), it will apply for anyone using published versions, even if the change is in submodules only. - By having the version check look up the expected version from the `package.json` file directly, we avoid having to modify both the `package.json` file and the check itself. Only the automatically generated single publish commit will trigger a forced rebuild, and satisfy the check on its own, - At the same time we remove the dependency of `agd build` onto the the internal structure of xsnap. ### Security Considerations Forces all validators to use the expected version of xsnap ### Scaling Considerations Does a few more checks when building xsnap, and causes full rebuilds in some cases where they might not be strictly necessary. ### Documentation Considerations Should all be transparent ### Testing Considerations Manually tested by touching the xsnap package version, or reverting just the release binary to a previous copy (or deleting altogether). If the binary is meddled with like this, `agd build` checks will fail, but a manual `yarn build` will fix. I thought this was better than transparently forcing a rebuild in that abnormal situation. ### Upgrade Considerations Smoother upgrades by validators
refs: #9622 ## Description Enforce the Node.js version in agd builder. Reverts #9619 This enforces LTS range, aka `^18.12` or `^20.9` through a regexp similar to the golang version check. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations We'll need to update release notes for validators to use `agd build` instead of the former `yarn install` and `yarn build` as that may still fail. If they still chose to go that route, they're on their own. ### Testing Considerations CI covers `agd build` ### Upgrade Considerations Smooth the transition away from previously supported Node v16 in upgrade-15
mhofman
force-pushed
the
mhofman/cherry-pick-u16-round-2
branch
from
55fc53a to
b0f1f66
Compare
Deploying agoric-sdk with
|
| Latest commit: |
f91b395
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6b460b6.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-cherry-pick-u16-roun.agoric-sdk.pages.dev |
refs: #9622 ## Description #9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
gibson042
approved these changes
Jul 1, 2024
|
@gibson042 I believe there is a late breaking change landing on master soon that needs inclusion in upgrade 16 |
Yep, an expected derivative of #9620. It'll get its own dev-upgrade-16 PR. |
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase todo