fix(vaultFactory): don't prevent repayment based on DebtLimit #9907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
1c94ac8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce22a673.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-test-repay.agoric-sdk.pages.dev |
turadg
reviewed
Aug 16, 2024
turadg
approved these changes
Aug 16, 2024
dckc
force-pushed
the
dc-test-repay
branch
2 times, most recently
from
4f6f522 to
2f24a49
Compare
Chris-Hibbert
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9837
Description
DebtLimit should not impact a vault owner's ability to repay, so refine
checkDebtLimitto succeed regardless ofdebtLimitiftoMintis empty.Security / Scaling Considerations
none
Testing Considerations
straightforward unit test that failed before the fix
Upgrade / Documentation Considerations
Straightforward upgrade; no state changes. See:
This fix should be cited in release notes.