Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v2.1.0 #165

Merged
merged 16 commits into from
Apr 20, 2019
Merged

release v2.1.0 #165

merged 16 commits into from
Apr 20, 2019

Conversation

HyunmoAhn
Copy link
Member

@HyunmoAhn HyunmoAhn commented Jan 23, 2019

Todo

  • End to End test config need to more information about electron e2e test
  • Search window e2e test
  • Widget window e2e test
  • Add some small feature
  • Code Structure refactoring
  • UI / UX Design Refactor

* Refactor about constant of path

* Config default setting information

* Edit unit test config and repair unit test code

* Fix title about page html

* E2E configure using spectron with jest

* Attach ipc handler to use e2e test

Spectron doesn't support controll of electron window.
So To use end to end test, Attach ipc handler on test environment.

* Add E2E support module

* Add window manager to control electron window on e2e environment

* Add test manager to use convenience

* Initial e2e code for search window

* E2E test main feature of list on search window

* E2E test feature of menu on search window

* Fix unit-test snapshot code
* add dbclick feature in list of search window.

when double click list of search widget, widget will be opened.

* Select whole address when double click address bar

* add reset button about address value
@coveralls
Copy link

coveralls commented Feb 13, 2019

Pull Request Test Coverage Report for Build 263

  • 78 of 218 (35.78%) changed or added relevant lines in 26 files are covered.
  • 78 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-13.3%) to 66.063%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/renderer/pages/search/components/SearchList/index.jsx 1 2 50.0%
app/renderer/pages/search/index.jsx 0 1 0.0%
app/store/middleware/categorizeActionInMain.js 0 1 0.0%
app/store/reducers/share/identification/widgetInfoById.js 2 3 66.67%
app/store/reducers/share/config/hotKeySearchWindow.js 0 3 0.0%
app/main/utils/menu/handlingSearchHotKey.js 0 5 0.0%
app/renderer/pages/search/components/SearchItem/index.jsx 8 13 61.54%
app/renderer/pages/search/components/SearchMoreMenu/index.jsx 4 9 44.44%
app/renderer/pages/widget/components/AddressBar/index.jsx 4 9 44.44%
app/e2e-ipc-handler.js 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
app/store/reducers/share/identification/widgetInfoById.js 1 89.29%
app/main/controllers/index.js 1 50.0%
app/store/reducers/share/config/selectors/index.js 1 87.5%
app/constants/i18n/widget.jsx 1 12.5%
app/store/reducers/share/status/selectors/index.js 3 78.57%
app/main/controllers/search.js 3 7.69%
app/main/controllers/widget.js 12 2.5%
app/renderer/pages/widget/components/ReloadTimer/index.jsx 21 9.3%
app/store/middleware/categorizeActionInMain.js 35 1.75%
Totals Coverage Status
Change from base Build 213: -13.3%
Covered Lines: 921
Relevant Lines: 1353

💛 - Coveralls

HyunmoAhn and others added 14 commits March 30, 2019 10:32
* code refactor for readability

* Optimization about preference window

- Delete action and store of preference
  - because It don't need to manage globally.
  - unnecessary action can cause confuse.

* Optimization about search window

* [WIP] Optimize of managing widget window

* Fix unit test code

* Delete update logic

- current update logic automatically update
- manually update doesn't need any more
* design search-view

* Fix snapshot on unit-test

* Config Svg inline component to controll svg attribute

* Apply react-svg-inline component on image of svg

* fix and redesign search & page view

* Widget Page view re-design & publishing

* Empty page and more menu on search window (#168)

* Fix double click event

* Add more menu in search window

* Empty page of search window

* search view and widget view republishing

* Fix overflow search menu on view-port

* fix address input padding

* fix unit test code
* update title when move page of widget

* fix error about refer of undefined
* fix unit test code

* adjust package script

* adjust webpack config file

* adjust babel config

* adjust jest config file

* adjust electron build config
@HyunmoAhn HyunmoAhn changed the title [Working in Progress] release v2.0.4 release v2.1.0 Apr 18, 2019
@HyunmoAhn HyunmoAhn merged commit c335d4b into master Apr 20, 2019
@HyunmoAhn HyunmoAhn deleted the release/2.0.4 branch April 20, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants