Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code refactoring for readability #162

Merged
merged 6 commits into from
Mar 30, 2019
Merged

code refactoring for readability #162

merged 6 commits into from
Mar 30, 2019

Conversation

HyunmoAhn
Copy link
Member

@HyunmoAhn HyunmoAhn commented Jan 13, 2019 •
edited
Loading

Notice

  • Clean up the config constant.
    • All config place on app/config.js
  • Attach IPC communication
    • Without IPC communication, Store has become very huge. So it is complicate.
    • I use IPC communication. And Store has necessary data like information of widget or oh-my-desk configure.
  • Delete manually update code.

@HyunmoAhn HyunmoAhn self-assigned this Jan 13, 2019
@coveralls
Copy link

coveralls commented Jan 31, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 247

  • 58 of 180 (32.22%) changed or added relevant lines in 19 files are covered.
  • 78 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-12.9%) to 66.467%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/store/middleware/categorizeActionInMain.js 0 1 0.0%
app/store/reducers/share/identification/widgetInfoById.js 2 3 66.67%
app/store/reducers/share/config/hotKeySearchWindow.js 0 3 0.0%
app/main/utils/menu/handlingSearchHotKey.js 0 5 0.0%
app/e2e-ipc-handler.js 0 6 0.0%
app/main/controllers/widget.js 0 8 0.0%
app/main/utils/window/openReduxDevTools.js 0 9 0.0%
app/main/utils/window/search.js 0 25 0.0%
app/main/utils/window/widget.js 18 48 37.5%
app/main.js 0 34 0.0%
Files with Coverage Reduction New Missed Lines %
app/main/controllers/index.js 1 50.0%
app/store/reducers/share/identification/widgetInfoById.js 1 89.29%
app/store/reducers/share/config/selectors/index.js 1 87.5%
app/constants/i18n/widget.jsx 1 12.5%
app/store/reducers/share/status/selectors/index.js 3 78.57%
app/main/controllers/search.js 3 7.69%
app/main/controllers/widget.js 12 2.5%
app/renderer/pages/widget/components/ReloadTimer/index.jsx 21 9.3%
app/store/middleware/categorizeActionInMain.js 35 1.75%
Totals Coverage Status
Change from base Build 213: -12.9%
Covered Lines: 906
Relevant Lines: 1320
💛 - Coveralls

@HyunmoAhn
Optimization about preference window
1667dd8 
- Delete action and store of preference
  - because It don't need to manage globally.
  - unnecessary action can cause confuse.
@HyunmoAhn HyunmoAhn changed the title [WIP] code refactoring for readability code refactoring for readability Mar 29, 2019
Delete update logic
dbe29a4 
- current update logic automatically update
- manually update doesn't need any more
@HyunmoAhn HyunmoAhn changed the base branch from master to release/2.0.4 March 30, 2019 01:31
@HyunmoAhn HyunmoAhn merged commit 2951f81 into release/2.0.4 Mar 30, 2019
@HyunmoAhn HyunmoAhn deleted the refactor/electron-main branch March 30, 2019 01:32
HyunmoAhn added a commit that referenced this pull request Apr 20, 2019
@HyunmoAhn
release v2.1.0 (#165)
c335d4b 
* Config of End-to-End & Search window e2e test code (#164)

* Refactor about constant of path

* Config default setting information

* Edit unit test config and repair unit test code

* Fix title about page html

* E2E configure using spectron with jest

* Attach ipc handler to use e2e test

Spectron doesn't support controll of electron window.
So To use end to end test, Attach ipc handler on test environment.

* Add E2E support module

* Add window manager to control electron window on e2e environment

* Add test manager to use convenience

* Initial e2e code for search window

* E2E test main feature of list on search window

* E2E test feature of menu on search window

* Fix unit-test snapshot code

* Add/feature 2.0.4 (#167)

* add dbclick feature in list of search window.

when double click list of search widget, widget will be opened.

* Select whole address when double click address bar

* add reset button about address value

* code refactoring for readability (#162)

* code refactor for readability

* Optimization about preference window

- Delete action and store of preference
  - because It don't need to manage globally.
  - unnecessary action can cause confuse.

* Optimization about search window

* [WIP] Optimize of managing widget window

* Fix unit test code

* Delete update logic

- current update logic automatically update
- manually update doesn't need any more

* design search-view (#166)

* design search-view

* Fix snapshot on unit-test

* Config Svg inline component to controll svg attribute

* Apply react-svg-inline component on image of svg

* fix and redesign search & page view

* Widget Page view re-design & publishing

* Empty page and more menu on search window (#168)

* Fix double click event

* Add more menu in search window

* Empty page of search window

* search view and widget view republishing

* Fix overflow search menu on view-port

* fix address input padding

* fix unit test code

* update taskbar title on widget of windowOS (#171)

* update title when move page of widget

* fix error about refer of undefined

* fix unit test code

* adjust package script

* adjust webpack config file

* adjust babel config

* adjust jest config file

* adjust electron build config

* upgrade husky & lint-staged

* adjust eslint config

* config release v2.1.0

* update download link latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HyunmoAhn HyunmoAhn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HyunmoAhn @coveralls