Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why polyfill Promise when you require Node v8? #179

Closed
steelbrain opened this issue Jun 7, 2020 · 0 comments · Fixed by #195
Closed

Why polyfill Promise when you require Node v8? #179

steelbrain opened this issue Jun 7, 2020 · 0 comments · Fixed by #195

Comments

@steelbrain
Copy link

Hi Airtable Team 👋

Opened this issue out of confusion, as per https://node.green/ basic Promises have been available since way back in Node.js v4. So why add it? Referencing #147

Also, if somebody is bundling this package for web, their whole app is gonna need promises, so they are better handled at app-level instead of package level, because if every package tries to polyfill their own, we end up with a bazillion Promise user-land implementations.
@rmeritz rmeritz mentioned this issue Jun 24, 2020
Merged
rmeritz added a commit to bocoup/airtable.js that referenced this issue Jul 23, 2020
@rmeritz
Remove Promise Polyfill
d7554c8 
The Promise polyfill is not needed with the outlined techinal
requirements for node or browser support.

Closes Airtable#179

A follow up to: Airtable#191
@rmeritz rmeritz mentioned this issue Jul 23, 2020
Merged
PeterPan627 added a commit to PeterPan627/airtable.js that referenced this issue May 28, 2023
@PeterPan627
Remove Promise Polyfill
2d6e15b 
The Promise polyfill is not needed with the outlined techinal
requirements for node or browser support.

Closes Airtable/airtable.js#179

A follow up to: Airtable/airtable.js#191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Promise Polyfill bocoup/airtable.js
1 participant
@steelbrain