Skip to content

Commit

Permalink
Remove Promise Polyfill
Browse files Browse the repository at this point in the history
The Promise polyfill is not needed with the outlined techinal
requirements for node or browser support.

Closes Airtable/airtable.js#179

A follow up to: Airtable/airtable.js#191
  • Loading branch information
PeterPan627 committed Jul 23, 2020
1 parent bd83f4a commit 2d6e15b
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 14 deletions.
3 changes: 3 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,5 +108,8 @@
"space-unary-ops": "warn",
"spaced-comment": "warn",
"yoda": "warn"
},
"globals": {
"Promise": "writable"
}
}
1 change: 0 additions & 1 deletion lib/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ var HttpHeaders = require('./http_headers');
var runAction = require('./run_action');
var packageVersion = require('./package_version');
var exponentialBackoffWithJitter = require('./exponential_backoff_with_jitter');
var Promise = require('./promise');

var userAgent = 'Airtable.js/' + packageVersion;

Expand Down
2 changes: 0 additions & 2 deletions lib/callback_to_promise.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
'use strict';

var Promise = require('./promise');

/**
* Given a function fn that takes a callback as its last argument, returns
* a new version of the function that takes the callback optionally. If
Expand Down
5 changes: 0 additions & 5 deletions lib/promise.js

This file was deleted.

5 changes: 0 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"dependencies": {
"abort-controller": "^3.0.0",
"abortcontroller-polyfill": "^1.4.0",
"es6-promise": "4.2.8",
"lodash": "4.17.15",
"node-fetch": "^2.6.0"
},
Expand Down

0 comments on commit 2d6e15b

Please sign in to comment.