fix: Correct the logic for tagged field defaults #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
aiven-anton/fix-omit-tagged-struct-by-implicit-defaults
branch
from
3445a6c
to
aa2b82c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 15 +1
Lines 854 915 +61
Branches 119 125 +6
=========================================
+ Hits 854 915 +61 ☔ View full report in Codecov by Sentry. |
aiven-anton
force-pushed
the
aiven-anton/fix-omit-tagged-struct-by-implicit-defaults
branch
from
aa2b82c
to
8be3f71
Compare
This fixes an issue where the logic for tagged fields was not in sync with upstream. This is in the realm of undocumented features of the Kafka protocol, so there is no accurate documentation to reference. The closest to documentation that exists, is [this section in a source code README][messages-readme]. [messages-readme]:https://github.com/apache/kafka/tree/4419677e06b77ed9103c179d713450b1eb7881a1/clients/src/main/resources/common/message#deserializing-messages There was a [long discussion] about this behavior on the Kafka dev mailing list. [long discussion]: https://www.mail-archive.com/dev@kafka.apache.org/msg144437.html This fixes #215.
aiven-anton
force-pushed
the
aiven-anton/fix-omit-tagged-struct-by-implicit-defaults
branch
from
8be3f71
to
55c4241
Compare
gpkc
deleted the
aiven-anton/fix-omit-tagged-struct-by-implicit-defaults
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the logic for tagged fields was not in sync with upstream. This is in the realm of undocumented features of the Kafka protocol, so there is no accurate documentation to reference. The closest to documentation that exists, is this section in a source code README.
There was a long discussion about this behavior on the Kafka dev mailing list.
This fixes #215.