Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct the logic for tagged field defaults #216

Merged
merged 2 commits into from
Nov 1, 2024
Merged

fix: Correct the logic for tagged field defaults #216

merged 2 commits into from
Nov 1, 2024

Commits on Oct 30, 2024

  1. fix: Correct the logic for tagged field defaults 

    This fixes an issue where the logic for tagged fields was not in sync
with upstream. This is in the realm of undocumented features of the
Kafka protocol, so there is no accurate documentation to reference. The
closest to documentation that exists, is [this section in a source code
README][messages-readme].

[messages-readme]:https://github.com/apache/kafka/tree/4419677e06b77ed9103c179d713450b1eb7881a1/clients/src/main/resources/common/message#deserializing-messages

There was a [long discussion] about this behavior on the Kafka dev
mailing list.

[long discussion]: https://www.mail-archive.com/dev@kafka.apache.org/msg144437.html

This fixes #215.
    @aiven-anton
    aiven-anton committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    09563ee View commit details
    Browse the repository at this point in the history

  2. chore: Drop xfail

    @aiven-anton
    aiven-anton committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    55c4241 View commit details
    Browse the repository at this point in the history