Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mail notification sent on topic promotion request. #1266

Closed
rts6637 opened this issue May 23, 2023 · 3 comments · Fixed by #1349
Closed

No mail notification sent on topic promotion request. #1266

rts6637 opened this issue May 23, 2023 · 3 comments · Fixed by #1349
Assignees
Labels
Backend Backend tasks bug Something isn't working

Comments

@rts6637
Copy link

rts6637 commented May 23, 2023

What happened?

Setup mail notifications.
Create a topic (receive notification)
Promote a topic - no notification sent/received

What did you expect to happen?

Klaw sends a notification on topic promotion request same way as topic creation reuqest.

What else do we need to know?

Klaw 2.3.0

@aindriu-aiven aindriu-aiven self-assigned this May 23, 2023
@aindriu-aiven aindriu-aiven added Backend Backend tasks bug Something isn't working labels May 23, 2023
@aindriu-aiven
Copy link
Contributor

Hey, I just wanted to confirm if you received no email?

I tested it there and I get a Topic Create email, for the promotion request - this should be improved to specify that it is promotion, but just wanted to check if that was the behaviour you were seeing or not.

Thanks,
Aindriú

@rts6637
Copy link
Author

rts6637 commented May 25, 2023

Hello Aindriú
I have retested and you are right, you receive mail notification for topic creation when you promote a topic, but in my case only the requestor (and requestor team) receives the email notification. Since #1258 was implemented i was expecting bcc email notification to approver but that one never arrived.

@aindriu-aiven
Copy link
Contributor

I'll look at the lack of bcc I would also like to make it obvious that it is a promotion request if I can so I will track those changes with this ticket.

Thanks for testing and getting back to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend tasks bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants