Issue promote topic email #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stored in the DB Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
core/src/main/java/io/aiven/klaw/dao/migration/MigrateData2x4x0.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/dao/migration/MigrateData2x4x0.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/aiven/klaw/dao/migration/MigrateData2x4x0.java
Outdated
Show resolved
Hide resolved
| tenantId); | ||
| schemaObjects = getSchemaFromAPI(topicNameSearch, tenantId, kwClusters); | ||
| if (schemaObjects != null) { | ||
| for (MessageSchema messageSchema : topicSchemaVersionsInDb) { |
There was a problem hiding this comment.
can this be empty in this else block ? do we need this
There was a problem hiding this comment.
It should technically throw an exception if the api fails to retrieve the data but I feel like it is safer to keep it in.
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
…o the db. Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Adds a specific subject and message for promotion and update of topic requests.
Resolves: #1266
Why this way