Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue email to all approvers #1258

Merged
merged 4 commits into from
May 19, 2023
Merged

Conversation

aindriu-aiven
Copy link
Contributor

@aindriu-aiven aindriu-aiven commented May 19, 2023

About this change - What it does
On Approvals, any user with the permission APPROVE_ALL_REQUESTS_TEAMS is sent a BCC email that a request has been created and is waiting approval.
Resolves: #1247
Why this way
This means that the CC line does not get filled up and does not expose lots of different users email address's in every email.

Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
Signed-off-by: Aindriu Lavelle <aindriu.lavelle@aiven.io>
@aindriu-aiven aindriu-aiven requested a review from a team as a code owner May 19, 2023 13:54
Copy link
Contributor

@muralibasani muralibasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@aindriu-aiven aindriu-aiven merged commit f1171c1 into main May 19, 2023
@aindriu-aiven aindriu-aiven deleted the issue-email-to-all-approvers branch May 19, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Klaw APPROVE_ALL_REQUESTS_TEAMS permission not working properly
2 participants