Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪸 Implement Form component based on Aiven console #141

Closed
programmiri opened this issue Oct 25, 2022 · 0 comments · Fixed by #159
Closed

🪸 Implement Form component based on Aiven console #141

programmiri opened this issue Oct 25, 2022 · 0 comments · Fixed by #159
Assignees
@programmiri
Labels
triaged Acknowledged
Milestone
Sprint 1: 18 Oct ...

Comments

@programmiri
Copy link
Contributor

programmiri commented Oct 25, 2022 •
edited
Loading

  • Implement Form component based on Aiven core (soon to be it's own OS package)
@programmiri programmiri self-assigned this Oct 27, 2022
@programmiri programmiri mentioned this issue Oct 27, 2022
Merged
@programmiri programmiri linked a pull request Oct 27, 2022 that will close this issue
coral: implement form component [#141] #159
Merged
SmuliS pushed a commit that referenced this issue Nov 1, 2022
@programmiri
coral: implement form component [#141] (#159)
57eb19c 
* feat: Add app directory and restructure related files.

* feat: Change unused vars to error for linting.

* feat: Add Form component based on aiven-core implementation.

* feat: Add userEvent package.

@testing-library/user-event has a peerDep for @testing-library/dom
but it's a different version than the one that @testing-library/react
uses and brings in as a devDep. Solution based on research on GitHub
shows we can either ignore the warning in pnpm or install the
@testing-library/dom as devDep in the version that @testing-library/react
uses it. I did the latter hoping that in one of the next versions of
@testing-library/user-event this will be resolved.

see
testing-library/user-event#438 (comment)
testing-library/user-event#551 (comment)

* feat: Add tests for Form based on aiven-core.

* feat: Introduce explicit typing for Form.

- remove use of 'any' type
- add stricter rule for use of any for linting

* feat: Update lodash usage to match dependencies.

* Remove comment about aiven-core mirroring

* Remove unused library.

* Rename and restructure pages files.

- `index.tsx` should be reserved for resource root
- files for pages can live on first level in `pages`
- rename files to match  naming conventions for react
- update documentation to be more explicit and correct

* Add login page to routing.

* Reorder lint rules after rebase.
@programmiri programmiri added this to the Sprint 1: 18 Oct - 1 Nov milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programmiri programmiri

Labels
triaged Acknowledged
Projects
None yet
Milestone
Sprint 1: 18 Oct - 1 Nov
Development

Successfully merging a pull request may close this issue.

coral: implement form component [#141] Aiven-Open/klaw
1 participant
@programmiri