coral: implement form component [#141] #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmiri
force-pushed
the
141-implement-form-component
branch
2 times, most recently
from
b08ea2a to
10b4736
Compare
programmiri
force-pushed
the
141-implement-form-component
branch
from
10b4736 to
deceda4
Compare
Closed
SmuliS
requested changes
Oct 31, 2022
SmuliS
changed the title
@testing-library/user-event has a peerDep for @testing-library/dom but it's a different version than the one that @testing-library/react uses and brings in as a devDep. Solution based on research on GitHub shows we can either ignore the warning in pnpm or install the @testing-library/dom as devDep in the version that @testing-library/react uses it. I did the latter hoping that in one of the next versions of @testing-library/user-event this will be resolved. see testing-library/user-event#438 (comment) testing-library/user-event#551 (comment)
- remove use of 'any' type - add stricter rule for use of any for linting
- `index.tsx` should be reserved for resource root - files for pages can live on first level in `pages` - rename files to match naming conventions for react - update documentation to be more explicit and correct
programmiri
force-pushed
the
141-implement-form-component
branch
from
b3f54d6 to
2d27275
Compare
SmuliS
approved these changes
Nov 1, 2022
| │ │ ├── page-one | ||
| │ │ ├── ... | ||
| │ │ └── index.ts | ||
| │ │ ├── index.tsx |
There was a problem hiding this comment.
I don't think want to even try to keep this up to date with current implementation so lets keep the examples abstract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #141
About this change - What it does
Adds a
Form.tsxcomponent based on a solution created for aiven-core.Why this way
Form.tsxonly implements the functionality we need for Klaw.esModuleInteropto true. Otherwise jest won't be able to handle it.allowSyntheticDefaultImports: truebecause that's set to true when usingesModuleInteropℹ️ for review
anyanyis now an error