Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generator: Node-Sass breaks on Node 16x. #111

Closed
6 of 11 tasks
tsalright opened this issue May 3, 2021 · 0 comments · Fixed by #123 or #79
Closed
6 of 11 tasks

Generator: Node-Sass breaks on Node 16x. #111

tsalright opened this issue May 3, 2021 · 0 comments · Fixed by #123 or #79
Assignees
@jason-capsule42
Labels
Type: Feature New Feature

Comments

@tsalright
Copy link

tsalright commented May 3, 2021 •
edited by blackfalcon
Loading

User story

As a developer, I want to be able to keep up with the latest node versions while continuing to use SASS, so I can keep up with security and feature improvements on newer version of Node.

Node-Sass will not work above Node 15x. It has been deprecated.

Outline tasks

List specific steps required to deliver this work

  • Replace Node-Sass with Dart-Sass

Definition of “Done” (exit criteria)

The story is generally “done” when the user can complete the outlined task, but make sure to define what that is.

Has been tested in all browsers

  • Chrome
  • Firefox
  • Edge (79 +)
  • Safari
  • Mobile Safari
  • IE11

Has been tested for accessibility

  • Screenreader
  • Axe
  • Keyboard use

Performance

  • Chrome Lighthhouse report
@blackfalcon blackfalcon removed their assignment May 3, 2021
@blackfalcon blackfalcon added Type: Feature New Feature and removed Status: Proposal labels May 3, 2021
@jason-capsule42 jason-capsule42 mentioned this issue May 12, 2021
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request May 12, 2021 that will close this issue
CI: Node sass to dart sass switch #123
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request May 13, 2021 that will close this issue
Generator: Next #79
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue May 14, 2021
@jason-capsule42 @blackfalcon
feat(dart-sass): update to dart-sass from node-sass #111
01960b2
blackfalcon pushed a commit that referenced this issue May 14, 2021
@jason-capsule42 @blackfalcon
feat(dart-sass): update to dart-sass from node-sass #111
f3c53e2
blackfalcon pushed a commit that referenced this issue May 17, 2021
@jason-capsule42 @blackfalcon
feat(dart-sass): update to dart-sass from node-sass #111
f6aa3fe
AuroDesignSystem pushed a commit that referenced this issue May 17, 2021
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
147f561 
# [3.0.0](v2.11.0...v3.0.0) (2021-05-17)

### Bug Fixes

* **husky:** update husky script to reference correct linters script ([a469915](a469915))

### Features

* **dart-sass:** update to dart-sass from node-sass [#111](#111) ([f6aa3fe](f6aa3fe))
* **generator init api:** update generator to use a single name input [#93](#93) ([d90e5d4](d90e5d4))
* **v3.0:** add remote eslint support [#62](#62) ([d5df429](d5df429))
* **v3.0:** update default npm namespace to [@AuroDesignSystem](https://github.com/aurodesignsystem) ([fc6f24e](fc6f24e))
* **v3.0:** update stylelintrc for extended support [#83](#83) ([c63c572](c63c572))
* **v3.0:** update to support fixed attr by default [#108](#108) ([69e06c6](69e06c6))

### BREAKING CHANGES

* **generator init api:** This update changes the generator
execution command. Removes supoprt for namespace argument
and instead uses single namespace-name argument.
* **v3.0:** This update will require that direct dependencies using the namespace
will need to be updated prior to release. This update will redirect all new packages to
be published in the new @AuroDesignSystem namespace.
jason-capsule42 pushed a commit that referenced this issue May 20, 2021
@semantic-release-bot @jason-capsule42
chore(release): 3.0.0 [skip ci]
664e93f 
# [3.0.0](v2.11.0...v3.0.0) (2021-05-17)

### Bug Fixes

* **husky:** update husky script to reference correct linters script ([a469915](a469915))

### Features

* **dart-sass:** update to dart-sass from node-sass [#111](#111) ([f6aa3fe](f6aa3fe))
* **generator init api:** update generator to use a single name input [#93](#93) ([d90e5d4](d90e5d4))
* **v3.0:** add remote eslint support [#62](#62) ([d5df429](d5df429))
* **v3.0:** update default npm namespace to [@AuroDesignSystem](https://github.com/aurodesignsystem) ([fc6f24e](fc6f24e))
* **v3.0:** update stylelintrc for extended support [#83](#83) ([c63c572](c63c572))
* **v3.0:** update to support fixed attr by default [#108](#108) ([69e06c6](69e06c6))

### BREAKING CHANGES

* **generator init api:** This update changes the generator
execution command. Removes supoprt for namespace argument
and instead uses single namespace-name argument.
* **v3.0:** This update will require that direct dependencies using the namespace
will need to be updated prior to release. This update will redirect all new packages to
be published in the new @AuroDesignSystem namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
3 participants
@blackfalcon @tsalright @jason-capsule42