Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Node sass to dart sass switch #123

Merged
merged 2 commits into from
May 14, 2021

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented May 12, 2021

Alaska Airlines Pull Request

Fixes: #111

Summary:

This change switches node-sass for dart-sass. Package scripts have been updated to call "sass" and use the updated : parameter syntax. This also required a small massage to the scss files to import paths to work properly.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jason-capsule42 jason-capsule42 self-assigned this May 12, 2021
@jason-capsule42 jason-capsule42 changed the base branch from master to next May 12, 2021 15:34
@jason-capsule42 jason-capsule42 linked an issue May 12, 2021 that may be closed by this pull request
11 tasks
@jason-capsule42 jason-capsule42 marked this pull request as ready for review May 12, 2021 15:39
@jason-capsule42 jason-capsule42 changed the title Build node sass to dart sass switch CI: Node sass to dart sass switch May 12, 2021
@jason-capsule42 jason-capsule42 added Type: Feature New Feature and removed Type: CI labels May 12, 2021
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label May 12, 2021
@blackfalcon blackfalcon force-pushed the build--node-sass-to-dart-sass-switch branch from 3cf8080 to 6aa605d Compare May 13, 2021 18:43
bin/generate.js Outdated Show resolved Hide resolved
bin/generate.js Outdated Show resolved Hide resolved
@blackfalcon blackfalcon force-pushed the build--node-sass-to-dart-sass-switch branch from da1bc8c to f80d87c Compare May 14, 2021 17:44
@blackfalcon blackfalcon force-pushed the build--node-sass-to-dart-sass-switch branch from f80d87c to 4425b28 Compare May 14, 2021 19:55
@blackfalcon blackfalcon merged commit ddd33f3 into next May 14, 2021
@blackfalcon blackfalcon deleted the build--node-sass-to-dart-sass-switch branch May 14, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator: Node-Sass breaks on Node 16x.
2 participants