Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: focus-visible support update #69

Closed
blackfalcon opened this issue Mar 5, 2021 · 2 comments · Fixed by #113
Closed

generator: focus-visible support update #69

blackfalcon opened this issue Mar 5, 2021 · 2 comments · Fixed by #113
Assignees
@blackfalcon
Labels
Type: Feature New Feature

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Mar 5, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

The generator assumes that focus-visible is not a supported feature and requires a polyfill for all browsers. This is not the case.

This pull request for auro-button removes that assumption.

Describe the solution you'd like

The update from the auro-button PR should be applied to WC-Generator to remove this assumption from future elements.

Be sure to update this doc
https://auro.alaskaair.com/support/polyfills/focusvisible
@blackfalcon blackfalcon mentioned this issue Mar 5, 2021
Merged
4 tasks
@blackfalcon blackfalcon mentioned this issue Mar 9, 2021
Closed
@blackfalcon blackfalcon self-assigned this Mar 9, 2021
@blackfalcon blackfalcon removed their assignment Mar 26, 2021
@blackfalcon blackfalcon self-assigned this Mar 26, 2021
@blackfalcon
Copy link
Member Author

I am not sure how we want to address this, but there is something to be done with this update and the issues behind AlaskaAirlines/WebCoreStyleSheets#69

I am using this issue to reference the other to ensure that there is a conclusion to both.

blackfalcon added a commit that referenced this issue May 7, 2021
@blackfalcon
feat: add support for focus-visible deprecation #69
a1fa98a
blackfalcon added a commit that referenced this issue May 7, 2021
@blackfalcon
feat: add support for focus-visible deprecation #69
7720f96
@blackfalcon blackfalcon changed the title generator: focus-visible support deprecation generator: focus-visible support update May 7, 2021
blackfalcon added a commit that referenced this issue May 7, 2021
@blackfalcon
feat: add support for nested focus-visible #69
19ecb02
@blackfalcon blackfalcon mentioned this issue May 7, 2021
Merged
6 tasks
blackfalcon added a commit that referenced this issue May 7, 2021
@blackfalcon
feat: add support for nested focus-visible #69
389c95b
@blackfalcon blackfalcon linked a pull request May 7, 2021 that will close this issue
Generator: focus-visible nested polyfill support #113
Merged
6 tasks
blackfalcon added a commit that referenced this issue May 10, 2021
@blackfalcon
feat: add support for nested focus-visible #69
bcb79ff
@blackfalcon blackfalcon mentioned this issue May 11, 2021
Closed
blackfalcon added a commit that referenced this issue May 11, 2021
@blackfalcon
feat: add support for nested focus-visible #69
13f634b
@blackfalcon blackfalcon added Status: Blocked Progress on the issue is blocked, immediate attention is required and removed Priority: High labels May 11, 2021
@blackfalcon
Copy link
Member Author

This story is blocked as there is a larger conversation to be had about its support and impact with users and tests.

There is no rush to get this addressed with the 3.0 release.

blackfalcon added a commit that referenced this issue May 13, 2021
@blackfalcon
feat: add support for nested focus-visible #69
5757db2
blackfalcon added a commit that referenced this issue May 14, 2021
@blackfalcon
feat: add support for nested focus-visible #69
478c2bf
blackfalcon added a commit that referenced this issue May 14, 2021
@blackfalcon
feat(focus-visible support): add support for nested focus-visible #69
99caa47
blackfalcon added a commit that referenced this issue May 14, 2021
@blackfalcon
feat(focus-visible support): add support for nested focus-visible #69
8f2fc58
@blackfalcon blackfalcon removed the Status: Blocked Progress on the issue is blocked, immediate attention is required label May 14, 2021
blackfalcon added a commit that referenced this issue May 17, 2021
@blackfalcon
feat(focus-visible support): add support for nested focus-visible #69
8b5b35f
blackfalcon added a commit that referenced this issue May 17, 2021
@blackfalcon
feat(focus-visible support): add support for nested focus-visible #69
707eb03
blackfalcon added a commit that referenced this issue May 17, 2021
@blackfalcon
fix(focus-visible support): adjust support for nested focus-visible #69
06d4015
blackfalcon added a commit that referenced this issue May 17, 2021
@blackfalcon
fix(focus-visible support): adjust support for nested focus-visible #69
f228c9d
blackfalcon added a commit that referenced this issue May 17, 2021
@blackfalcon
fix(focus-visible support): adjust support for nested focus-visible #69
7e555c4
AuroDesignSystem pushed a commit that referenced this issue May 17, 2021
@semantic-release-bot
chore(release): 3.0.2 [skip ci]
4e2e08d 
## [3.0.2](v3.0.1...v3.0.2) (2021-05-17)

### Bug Fixes

* **focus-visible support:** adjust support for nested focus-visible [#69](#69) ([7e555c4](7e555c4))
* **gitignore:** update incorrect ignore settings ([42b9544](42b9544))
jason-capsule42 pushed a commit that referenced this issue May 20, 2021
@blackfalcon @jason-capsule42
fix(focus-visible support): adjust support for nested focus-visible #69
d038d4e
jason-capsule42 pushed a commit that referenced this issue May 20, 2021
@semantic-release-bot @jason-capsule42
chore(release): 3.0.2 [skip ci]
58d1ce5 
## [3.0.2](v3.0.1...v3.0.2) (2021-05-17)

### Bug Fixes

* **focus-visible support:** adjust support for nested focus-visible [#69](#69) ([7e555c4](7e555c4))
* **gitignore:** update incorrect ignore settings ([42b9544](42b9544))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generator: focus-visible nested polyfill support AlaskaAirlines/WC-Generator
1 participant
@blackfalcon