-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator: focus-visible nested polyfill support #113
Conversation
19ecb02
to
389c95b
Compare
Going to investigate further on Monday, but it seems that JSDOM throws an error when the polyfill is applied to a shadow root. I want to see if there's a way to mitigate this before adding it to the generator. |
389c95b
to
27594e2
Compare
Marked this issue as BLOCKED until I hear back from @geoffrich
|
Working on it. Trying to make a minimal JSDOM repro. |
Okay, turns out this is not a false alarm. Loading the polyfill in the constructor applies an attribute to the element, and this is a violation of the spec for custom element constructors:
I think we need to move the polyfill loading to connectedCallback instead. @blackfalcon I can apply the changes first in auro-button and then to this WC-Generator branch once everything works. I should be able to complete that work tomorrow. |
See AlaskaAirlines/auro-button#112 for the associated button issue. |
I am thinking that the document update stays, but the code will not. And the days of supporting this polyfill are numbered. |
27594e2
to
f5081d2
Compare
a4bfb91
to
6fee1fc
Compare
1f4248b
to
ae93333
Compare
@geoffrich the scope of this PR has been reduced to only document and style changes. The issue related to nested elements is still an open discussion. |
ae93333
to
4fca9e9
Compare
Co-authored-by: Geoff Rich <geoff.rich@alaskaair.com>
6ff900b
to
d984b9f
Compare
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
This PR will add new documentation and demo support for how the
focus-visible
pseudo class works when natively supported and when the polyfill is in use.It has been discovered that the process from which to support nested elements and the polyfill is causing other issues and will not be included within the scope of this PR.
Resolves: #69
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team