Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release is missing required assets #56

Closed
blackfalcon opened this issue Apr 17, 2023 · 2 comments · Fixed by #58
Closed

Release is missing required assets #56

blackfalcon opened this issue Apr 17, 2023 · 2 comments · Fixed by #58
Assignees
@blackfalcon
Labels
auro-badge Type: Bug Bug or Bug fixes
Milestone
Badge: Node 18+ s...

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Apr 17, 2023 •
edited
Loading

Please verify the version of auro-badge you have installed

1.2.4

Please describe the bug

The delivered version of index.js has a dependency on ./src/auro-badge.js which is not in the delivered package. We need to update the package and include ./src/auro-badge.js

See https://www.runpkg.com/?@aurodesignsystem/auro-badge@2.0.0/index.js

Reproducing the error on the docsite

No I can't

Expected behavior

The installed element should operate as expected.

What browsers are you seeing the problem on?

No response

Additional context

n/a
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes auro-badge labels Apr 17, 2023
@blackfalcon blackfalcon added this to the Badge: Node 18+ support milestone Apr 17, 2023
@blackfalcon
Copy link
Member Author

blackfalcon commented Apr 17, 2023 •
edited
Loading

The issue is related to the fact that the src resources are not included with the npm package.

See this file as a reference to correct.
https://github.com/AlaskaAirlines/auro-hyperlink/blob/main/.npmignore

Exit criteria

This issue can be closed once the update includes the necessary components of the source files.

To validate, run npm pack to create a local version of a npm package from prod. Ensure that the .js file is included in the ./src directory.

@blackfalcon
Copy link
Member Author

/duplicate

@blackfalcon blackfalcon mentioned this issue Apr 17, 2023
Closed
@AuroDesignSystem AuroDesignSystem mentioned this issue Apr 17, 2023
Closed
blackfalcon added a commit that referenced this issue Apr 18, 2023
@blackfalcon
fix(npm): update ignore to include src assets #56
e9a918d 
Changes to be committed:
modified:   .npmignore
@blackfalcon blackfalcon mentioned this issue Apr 18, 2023
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Apr 18, 2023 that will close this issue
Update npm ignore #58
Merged
6 tasks
@blackfalcon blackfalcon self-assigned this Apr 18, 2023
blackfalcon added a commit that referenced this issue Apr 18, 2023
@blackfalcon
fix(npm): update ignore to include src assets #56
d446c25 
Changes to be committed:
modified:   .npmignore
blackfalcon pushed a commit that referenced this issue Apr 18, 2023
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
b671178 
## [2.0.1](v2.0.0...v2.0.1) (2023-04-18)

### Bug Fixes

* **npm:** update ignore to include src assets [#56](#56) ([d446c25](d446c25))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-badge Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
Badge: Node 18+ support
Development

Successfully merging a pull request may close this issue.

Update npm ignore AlaskaAirlines/auro-badge
1 participant
@blackfalcon