Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release is missing required assets #74

Closed
AuroDesignSystem opened this issue Apr 17, 2023 · 1 comment · Fixed by #72 or #76
Closed

Release is missing required assets #74

AuroDesignSystem opened this issue Apr 17, 2023 · 1 comment · Fixed by #72 or #76
Assignees
@irma-kurnia-alaska
Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Milestone
Icon: Node 18+ su...

Comments

@AuroDesignSystem
Copy link
Collaborator

AuroDesignSystem commented Apr 17, 2023 •
edited by blackfalcon
Loading

Please verify the version of auro-badge you have installed

3.4.1

Please describe the bug

The delivered version of index.js has a dependency on ./src/auro-icon.js which is not in the delivered package. We need to update the package and include ./src/auro-icon.js

Expected behavior

The installed element should operate as expected.

This issue was copied from #86 by @blackfalcon.
@AuroDesignSystem AuroDesignSystem added the Type: Bug Bug or Bug fixes label Apr 17, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-header Apr 17, 2023
@blackfalcon
Copy link
Member

The issue is related to the fact that the src resources are not included with the npm package.

See this file as a reference to correct.
https://github.com/AlaskaAirlines/auro-hyperlink/blob/main/.npmignore

Exit criteria

This issue can be closed once the update includes the necessary components of the source files.

@blackfalcon blackfalcon added this to the Icon: Node 18+ support milestone Apr 17, 2023
@Izook Izook self-assigned this Apr 17, 2023
@Izook Izook mentioned this issue Apr 17, 2023
Merged
6 tasks
@Izook Izook linked a pull request Apr 17, 2023 that will close this issue
Update .npmignore #75
Merged
6 tasks
@blackfalcon blackfalcon removed a link to a pull request Apr 17, 2023
Update .npmignore #75
Merged
6 tasks
irma-kurnia-alaska pushed a commit that referenced this issue Apr 18, 2023
@irma-kurnia-phtn
chore(configs): release is missing required assets #74
4fd4c80
@irma-kurnia-alaska irma-kurnia-alaska self-assigned this Apr 18, 2023
@irma-kurnia-alaska irma-kurnia-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label Apr 18, 2023
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue Apr 18, 2023
Merged
3 tasks
@irma-kurnia-alaska irma-kurnia-alaska linked a pull request Apr 18, 2023 that will close this issue
Node 18+ Update #72
Merged
3 tasks
@Izook Izook mentioned this issue Apr 18, 2023
Merged
3 tasks
@Izook Izook linked a pull request Apr 18, 2023 that will close this issue
fix(resources): update .npmignore #76
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Apr 19, 2023
@irma-kurnia-phtn @blackfalcon
chore(configs): release is missing required assets #74
a30fd86
blackfalcon pushed a commit that referenced this issue Apr 21, 2023
@irma-kurnia-phtn @blackfalcon
chore(configs): release is missing required assets #74
138c0c7
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "chore(configs): release is missing required assets #74"
8cab3fe 
This reverts commit 27e6ba9.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "chore(configs): release is missing required assets #74"
a373a68 
This reverts commit 27e6ba9.
blackfalcon added a commit that referenced this issue Apr 21, 2023
@blackfalcon
Revert "chore(configs): release is missing required assets #74"
bc6f712 
This reverts commit 27e6ba9.
AuroDesignSystem pushed a commit that referenced this issue Apr 21, 2023
@semantic-release-bot
chore(release): 3.4.4 [skip ci]
81d2021 
## [3.4.4](v3.4.3...v3.4.4) (2023-04-21)

### Reverts

* Revert "perf(es5): Remove legacy es5 bundling resources #63" ([82669c2](82669c2)), closes [#63](#63)
* Revert "perf(sass): Update Sass to use dart-sass dependency #64" ([dded5b0](dded5b0)), closes [#64](#64)
* Revert "perf(husky): pre-commit and husky update #65" ([654a082](654a082)), closes [#65](#65)
* Revert "docs(template): update issue templates #70" ([7419b12](7419b12)), closes [#70](#70)
* Revert "build(npm): update npm namespace #71" ([f03729f](f03729f)), closes [#71](#71)
* Revert "feat(ts): add support for typescript users #69" ([1b45723](1b45723)), closes [#69](#69)
* Revert "chore(deps): full dependency update" ([25bb33c](25bb33c))
* Revert "perf(lit): update component to Lit2.0 #68" ([687e89a](687e89a)), closes [#68](#68)
* Revert "perf(server): update to use single shell" ([034e846](034e846))
* Revert "perf(node18): update core features to support node 18+ #66" ([1b0fb9a](1b0fb9a)), closes [#66](#66)
* Revert "chore(configs): release is missing required assets #74" ([bc6f712](bc6f712)), closes [#74](#74)
* Revert "feat() : support element name extension feature #62" ([d9fe35a](d9fe35a)), closes [#62](#62)
* Revert "docs(issues): update bug template" ([2221afd](2221afd))
* Revert "feat(ts): move the package of typescript into devDependencies" ([789a6f4](789a6f4))
* Revert "chore(deps): full dependency update" ([26aadc9](26aadc9))
* Revert "chore: additional cleanup of legacy code This commit removes legacy content from current resources and deleted files that are no longer required." ([79c61dc](79c61dc))
* Revert "deps: remove unused resources" ([9eaba53](9eaba53))
* Revert "chore: remove unused resource" ([a720ef9](a720ef9))
* Revert "chore: cleanup of legacy code" ([d2151d0](d2151d0))
* Revert "build(husky): remove package.json config #65" ([d2b00ee](d2b00ee)), closes [#65](#65)
* Revert "build(husky): update package-lock.json" ([0dc802c](0dc802c))
* Revert "build: update automated api generation script" ([b3a8021](b3a8021))
* Revert "docs: update to component registration function" ([fe459d3](fe459d3))
* Revert "build(husky): update resource to be executable #65" ([f1d83e0](f1d83e0)), closes [#65](#65)
* Revert "docs: update postinstall message" ([361a4a0](361a4a0))
blackfalcon pushed a commit that referenced this issue Apr 21, 2023
@irma-kurnia-phtn @blackfalcon
chore(configs): release is missing required assets #74
231ac15
@blackfalcon blackfalcon mentioned this issue Apr 21, 2023
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue Apr 22, 2023
@irma-kurnia-phtn @blackfalcon
chore(configs): release is missing required assets #74
cd4757f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irma-kurnia-alaska irma-kurnia-alaska

Labels
Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
Icon: Node 18+ support
4 participants
@blackfalcon @Izook @AuroDesignSystem @irma-kurnia-alaska