Node 18+ Update #72
Merged
Node 18+ Update #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irma-kurnia-alaska
added
Type: Refactoring
|
|
|
@irma-kurnia-alaska when working on issues, please link the issue to the DEVELOPMENT area of the PR as well as add them to the content of the PR. Thanks. I added these first three. Also, please use DRAFT PR while all the work is in progress. Labels and Milestones are NOT needed for PRs. We only tag the ISSUES. |
This was
linked to
issues
Apr 17, 2023
blackfalcon
removed
Type: Refactoring
|
Hi @dale ***@***.***>,
Sorry and thank you for your feedback. I will add them for the content of the PR. Thank you so much.
Dapatkan Outlook untuk Android<https://aka.ms/AAb9ysg>
…________________________________
From: Dale Sande ***@***.***>
Sent: Monday, April 17, 2023 9:50:49 PM
To: AlaskaAirlines/auro-icon ***@***.***>
Cc: Irma Kurnia ***@***.***>; Mention ***@***.***>
Subject: Re: [AlaskaAirlines/auro-icon] Node 18+ Update (PR #72)
[EXTERNAL SENDER]
@irma-kurnia-alaska<https://github.com/irma-kurnia-alaska> when working on issues, please link the issue to the DEVELOPMENT area of the PR as well as add them to the content of the PR. Thanks. I added these first three.
—
Reply to this email directly, view it on GitHub<#72 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5XE7PQNLIYAEMWGZFZFU5LXBVKETANCNFSM6AAAAAAXA2EC4E>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
No need to apologize. You’re doing great. Just some helpful adjustments while onboarding to this project.
Thanks for your help.
—Dale
…________________________________
From: Irma Kurnia ***@***.***>
Sent: Monday, April 17, 2023 8:23:19 AM
To: AlaskaAirlines/auro-icon ***@***.***>; AlaskaAirlines/auro-icon ***@***.***>; Dale Sande ***@***.***>
Cc: Mention ***@***.***>
Subject: Re: [AlaskaAirlines/auro-icon] Node 18+ Update (PR #72)
Hi @dale ***@***.***>,
Sorry and thank you for your feedback. I will add them for the content of the PR. Thank you so much.
Dapatkan Outlook untuk Android<https://aka.ms/AAb9ysg>
________________________________
From: Dale Sande ***@***.***>
Sent: Monday, April 17, 2023 9:50:49 PM
To: AlaskaAirlines/auro-icon ***@***.***>
Cc: Irma Kurnia ***@***.***>; Mention ***@***.***>
Subject: Re: [AlaskaAirlines/auro-icon] Node 18+ Update (PR #72)
[EXTERNAL SENDER]
@irma-kurnia-alaska<https://github.com/irma-kurnia-alaska> when working on issues, please link the issue to the DEVELOPMENT area of the PR as well as add them to the content of the PR. Thanks. I added these first three.
—
Reply to this email directly, view it on GitHub<#72 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5XE7PQNLIYAEMWGZFZFU5LXBVKETANCNFSM6AAAAAAXA2EC4E>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thank you @dale ***@***.***>.. My pleasure to help.
Dapatkan Outlook untuk Android<https://aka.ms/AAb9ysg>
…________________________________
From: Dale Sande ***@***.***>
Sent: Monday, April 17, 2023 10:25:55 PM
To: Irma Kurnia ***@***.***>; AlaskaAirlines/auro-icon ***@***.***>; AlaskaAirlines/auro-icon ***@***.***>
Cc: Mention ***@***.***>
Subject: Re: [AlaskaAirlines/auro-icon] Node 18+ Update (PR #72)
No need to apologize. You’re doing great. Just some helpful adjustments while onboarding to this project.
Thanks for your help.
—Dale
________________________________
From: Irma Kurnia ***@***.***>
Sent: Monday, April 17, 2023 8:23:19 AM
To: AlaskaAirlines/auro-icon ***@***.***>; AlaskaAirlines/auro-icon ***@***.***>; Dale Sande ***@***.***>
Cc: Mention ***@***.***>
Subject: Re: [AlaskaAirlines/auro-icon] Node 18+ Update (PR #72)
Hi @dale ***@***.***>,
Sorry and thank you for your feedback. I will add them for the content of the PR. Thank you so much.
Dapatkan Outlook untuk Android<https://aka.ms/AAb9ysg>
________________________________
From: Dale Sande ***@***.***>
Sent: Monday, April 17, 2023 9:50:49 PM
To: AlaskaAirlines/auro-icon ***@***.***>
Cc: Irma Kurnia ***@***.***>; Mention ***@***.***>
Subject: Re: [AlaskaAirlines/auro-icon] Node 18+ Update (PR #72)
[EXTERNAL SENDER]
@irma-kurnia-alaska<https://github.com/irma-kurnia-alaska> when working on issues, please link the issue to the DEVELOPMENT area of the PR as well as add them to the content of the PR. Thanks. I added these first three.
—
Reply to this email directly, view it on GitHub<#72 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5XE7PQNLIYAEMWGZFZFU5LXBVKETANCNFSM6AAAAAAXA2EC4E>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@irma-kurnia-alaska a few things when coming back to this. Generally, all commits should come with a body in the message. Please see the auro-badge examples, for example... This is VERY important when it comes to this issue of updating the namespace. This is a BREAKING CHANGE and the body of the commit MUST have the
Just a reminder. All the issues in this milestone are in an order that provides the best experience when making updates. Please do them in the order that they are listed. I.e. #62, #63, #64, etc... Your PR is missing #62. |
This was
linked to
issues
Apr 18, 2023
Closed
Closed
Closed
Closed
Closed
blackfalcon
requested changes
Apr 18, 2023
BREAKING CHANGE: This update requires a MAJOR release as the namespace of the element has been changed. Changes to be committed: modified: README.md modified: package.json
This issue updates the bug report template to clarify some of the content when form is completed. Changes to be committed: modified: .github/ISSUE_TEMPLATE/bug_report.yml .github/CODEOWNERS .github/ISSUE_TEMPLATE/feature_request.yml .github/ISSUE_TEMPLATE/general-support.yml
Changes to be committed: modified: package-lock.json package.json
Changes to be committed: modified: package-lock.json package.json scripts/postCss.js
This commit removes legacy content from current resources and deleted files that are no longer required. Changes to be committed: modified: demo/index.html deleted: demo/sass/style.scss deleted: polymer.json
Changes to be committed: modified: package-lock.json modified: package.json
Changes to be committed: deleted: index.html
This commit removes legacy content from current resources. Changes to be committed: modified: README.md modified: src/auro-alaska.js modified: src/auro-icon.js modified: src/baseIcon.js
Changes to be committed: modified: package.json
Changes to be committed: modified: package-lock.json
Changes to be committed: modified: package.json
Changes to be committed: modified: src/auro-alaska.js modified: src/auro-icon.js
Changes to be committed: modified: .husky/pre-commit
blackfalcon
force-pushed
the
irmaku/node18update
branch
from
894c2c2 to
dc1f5a7
Compare
Changes to be committed: modified: packageScripts/postinstall.js
This commit updates the package-lock to the most recent version of npm and removes unnecessary dependencies from the repo. Changes to be committed: modified: package-lock.json modified: package.json
blackfalcon
approved these changes
Apr 21, 2023
Merged
|
🎉 This PR is included in version 3.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #62, #63, #64, #65, #66, #67, #68, #69, #70, #71, #74
Summary:
...
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- JetStream Design System Team