Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-button: unstyled, icon only varient #252

Closed
jason-capsule42 opened this issue Jul 1, 2024 · 1 comment · Fixed by #255 or #259
Closed

auro-button: unstyled, icon only varient #252

jason-capsule42 opened this issue Jul 1, 2024 · 1 comment · Fixed by #255 or #259
Assignees

Comments

@jason-capsule42
Copy link
Member

Is your feature request related to a problem? Please describe.

Several of our other components use raw HTML tags to create clickable elements and place an icon inside of them. These buttons are providing incomplete and inconsistent experiences.

Describe the solution you'd like

I would like to see a varient of auro-button that that has no content styles and is for use with auro-icon as the slot content. This varient would simply pass down the state variations (e.g. disabled) to the slot content auro-icon and use the variant styles of that component.

This would simply the CSS code for parent components like Drawer and Dialog and provide that consistent user experience our customers expect.

Describe alternatives you've considered

Do nothing and leave it as it is.

Additional context

No response

Exit criteria

To be determined by triage process and the team.

@jason-capsule42 jason-capsule42 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members auro-button labels Jul 1, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jul 1, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Jul 1, 2024
@jason-capsule42 jason-capsule42 linked a pull request Jul 4, 2024 that will close this issue
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Jul 8, 2024 that will close this issue
6 tasks
blackfalcon pushed a commit that referenced this issue Jul 8, 2024
# [7.3.0-beta.5](v7.3.0-beta.4...v7.3.0-beta.5) (2024-07-08)

### Performance Improvements

* **flat:** use the correct new tokens for the flat variant [#252](#252) ([0e6576f](0e6576f))
jason-capsule42 pushed a commit that referenced this issue Sep 10, 2024
* **flat:** use the correct new tokens for the flat variant [#252](#252) ([0e6576f](0e6576f))
jason-capsule42 pushed a commit that referenced this issue Sep 10, 2024
* **flat:** use the correct new tokens for the flat variant [#252](#252) ([0e6576f](0e6576f))
blackfalcon pushed a commit that referenced this issue Sep 10, 2024
# [7.3.0](v7.2.10...v7.3.0) (2024-09-10)

### Bug Fixes

* **flat:** change width CSS rules to 'unset' for the flat variant ([610dd4b](610dd4b))
* **flat:** correct colors in ondark flat variant ([2e34651](2e34651))
* **flat:** remove focus border from flat variant ([1b6acb7](1b6acb7))

### Features

* **flat:** add new flat variant for use in auro-components ([afb87d3](afb87d3))
* force new feature release ([ec4c6f1](ec4c6f1))
* **themes:** update styles to support component themes [#243](#243) ([acc481e](acc481e))

### Performance Improvements

* **flat:** use the correct new tokens for the flat variant [#252](#252) ([349edc3](349edc3))
* **loader:** use beta version of loader as direct dependency ([7e925af](7e925af))
* update design tokens and eslint config ([cfefc60](cfefc60))
@jordanjones243
Copy link
Contributor

The work for this is a part of the v7.3.0 release and this ticket can therefore be closed.

@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
@jason-capsule42 jason-capsule42 self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants