Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #13

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 4 comments · Fixed by #14 or #19
Closed
2 tasks

Update color tokens for theming support #13

jordanjones243 opened this issue Mar 13, 2024 · 4 comments · Fixed by #14 or #19
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature auro-dialog labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

jordanjones243 commented Mar 13, 2024

  • Hardcoded
    • Dialog overlay —open:
      • Background: rgba(0, 0, 0, 0.2);
    • Dialog overlay —modal:
      • Background: rgba(0, 0, 0, 0.5);
    • box-shadow: 0 10px 20px 0 rgba(0,0,0,0.12), 0 1px 10px 0 rgba(0,0,0,0.1);
    • Transparent
  • Tier 1
    • Unformatted ondark dialog header action color: var(--ds-color-base-white, $ds-color-base-white);

@jordanjones243
Copy link
Contributor Author

This ticket will be blocked until this work is completed:

jordanjones243 pushed a commit that referenced this issue Jul 4, 2024
# [1.1.0-beta.1](v1.0.9...v1.1.0-beta.1) (2024-07-04)

### Features

* refactor color token structure with tier 3 tokens [#13](#13) ([179e468](179e468))
* **version:** use custom versioned auro components ([8de7e7c](8de7e7c))
@jordanjones243 jordanjones243 linked a pull request Aug 14, 2024 that will close this issue
6 tasks
@jordanjones243
Copy link
Contributor Author

Blocked by auro-button color theming support release.

@jordanjones243
Copy link
Contributor Author

jordanjones243 commented Sep 19, 2024

Need design to revise the semantic tokens being used within the tokens.scss file. @leeejune

@jason-capsule42 jason-capsule42 removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 30, 2024
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
jordanjones243 added a commit that referenced this issue Oct 3, 2024
BREAKING CHANGE: trigger major release for color theme support #13
jordanjones243 added a commit that referenced this issue Oct 3, 2024
BREAKING CHANGE: trigger major release for color theme support #13
jordanjones243 added a commit that referenced this issue Oct 3, 2024
BREAKING CHANGE: trigger major release for color theme support #13
jordanjones243 pushed a commit that referenced this issue Oct 3, 2024
# [2.0.0-beta.1](v1.1.0-beta.2...v2.0.0-beta.1) (2024-10-03)

### Bug Fixes

* resolve minor color theming issues ([04aed67](04aed67))

### Features

* add tag name as attribute when custom registered ([e749245](e749245))

### Performance Improvements

* refactor custom component registration config ([5c1afc8](5c1afc8))
* update dependencies ([eea1e4f](eea1e4f))

### BREAKING CHANGES

* trigger major release for color theme support #13
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
# [1.1.0-beta.1](v1.0.9...v1.1.0-beta.1) (2024-07-04)

### Features

* refactor color token structure with tier 3 tokens [#13](#13) ([179e468](179e468))
* **version:** use custom versioned auro components ([8de7e7c](8de7e7c))
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
BREAKING CHANGE: trigger major release for color theme support #13
jason-capsule42 pushed a commit that referenced this issue Oct 4, 2024
# [2.0.0-beta.1](v1.1.0-beta.2...v2.0.0-beta.1) (2024-10-03)

### Bug Fixes

* resolve minor color theming issues ([04aed67](04aed67))

### Features

* add tag name as attribute when custom registered ([e749245](e749245))

### Performance Improvements

* refactor custom component registration config ([5c1afc8](5c1afc8))
* update dependencies ([eea1e4f](eea1e4f))

### BREAKING CHANGES

* trigger major release for color theme support #13
jordanjones243 pushed a commit that referenced this issue Oct 4, 2024
# [2.0.0](v1.0.9...v2.0.0) (2024-10-04)

### Bug Fixes

* resolve minor color theming issues ([d114353](d114353))

### Features

* add tag name as attribute when custom registered ([6b846d2](6b846d2))
* refactor color token structure with tier 3 tokens [#13](#13) ([f5243a5](f5243a5))
* **version:** use custom versioned auro components ([e8a46bb](e8a46bb))

### Performance Improvements

* **button:** use new version of flat variant button ([450c28a](450c28a))
* refactor custom component registration config ([abe479a](abe479a))
* update dependencies ([204145c](204145c))

### BREAKING CHANGES

* trigger major release for color theme support #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants