Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Theme Color Issues #253

Closed
jason-capsule42 opened this issue Jul 2, 2024 · 0 comments
Closed

Beta Theme Color Issues #253

jason-capsule42 opened this issue Jul 2, 2024 · 0 comments
Assignees

Comments

@jason-capsule42
Copy link
Member

jason-capsule42 commented Jul 2, 2024

Please verify the version of auro-button you have installed

No response

Please describe the bug

Border inset color is wrong

--ds-auro-button-border-inset-color: var(--ds-color-border-emphasis-inverse, $ds-color-border-emphasis-inverse);

The token being used here is correct but the color is actual pink rather than the expected white

Loader Color

--ds-auro-button-loader-color: var(--ds-color-background-darkest, $ds-color-background-darkest);

OnDark flat variant hover color

The default color for the icon in this case is var(--ds-color-icon-ui-secondary-default-inverse);, but the hovered color is lighter and seems wrong var(--ds-color-icon-ui-secondary-hover-inverse);

There is no equivalent tier 2 token for this.

Reproducing the error on the docsite

None

Expected behavior

Need final color definitions from design team.

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response

@jason-capsule42 jason-capsule42 added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members auro-button labels Jul 2, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jul 3, 2024
@jordanjones243 jordanjones243 linked a pull request Sep 23, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 self-assigned this Sep 23, 2024
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 23, 2024
blackfalcon pushed a commit that referenced this issue Sep 25, 2024
# [8.0.0](v7.3.0...v8.0.0) (2024-09-25)

### Bug Fixes

* resolve color theming issues [#253](#253) ([2e57c03](2e57c03))

### Performance Improvements

* refactor custom component registration config ([7ea8420](7ea8420))
* update file extension and names ([ca89972](ca89972))
* use latest versions of dependencies ([8af1108](8af1108))

### BREAKING CHANGES

* trigger major release for color theming support #229
@jason-capsule42 jason-capsule42 removed the Type: Bug Bug or Bug fixes label Oct 3, 2024
@jordanjones243 jordanjones243 removed a link to a pull request Oct 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants