-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address color theming issues #264
Conversation
Reviewer's Guide by SourceryThis pull request addresses color theming issues in the auro-button component by updating the use of design tokens, introducing a new 'flat' variant, and making several other improvements to enhance consistency and maintainability. The changes include updating dependencies, refactoring color-related code, correcting attribute naming, updating documentation, and removing obsolete scripts. File-Level Changes
Sequence DiagramsequenceDiagram
participant U as User
participant B as auro-button
participant T as Design Tokens
U->>B: Interact (hover/active/disabled)
B->>T: Request updated color values
T-->>B: Return appropriate color tokens
B->>B: Apply updated colors
B-->>U: Display updated button state
Tips
|
9756f53
to
1e2c1a6
Compare
Surge demo deployment failed! 😭 |
1e2c1a6
to
56c98b7
Compare
56c98b7
to
62c1b85
Compare
BREAKING CHANGE: trigger major release for color theming support #229
62c1b85
to
243dcb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding an explanation in the PR description about the changes to component registration, as this affects how developers will use the component.
- Please confirm that the functionality of the removed scripts (generateDocs.mjs, prepForBuild.js) is no longer needed or has been moved elsewhere.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #253
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Address color theming issues by updating design tokens and refactoring component registration to use auro-library's runtime utilities. Remove outdated build scripts and update documentation and tests accordingly.
Enhancements:
Build:
Documentation:
Tests: