feat(serde-json-impl): handle bool for serde_json::Value #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
boolean
to the TS type forserde_json::Value
Notes
boolean
is a correct type in JSONs, and is one of the possible variants ofserde_json::Value
, so I think it makes sense to add it to the generated TS typeChanges
TsJsonValue
=>Boolean(bool)
| boolean
in the unit tests forserde-json-impl
featureChecklist