Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include null in serde_json::Value #359

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

NyxCode
Copy link
Collaborator

@NyxCode NyxCode commented Oct 7, 2024

Goal

null was missing from serde_json::Value.
See #358.

Checklist

  • [ ] I have followed the steps listed in the Contributing guide.
  • [ ] If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@NyxCode
Copy link
Collaborator Author

NyxCode commented Oct 7, 2024

image

Copy link
Collaborator

@gustavo-shigueo gustavo-shigueo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gustavo-shigueo gustavo-shigueo merged commit 5504e9f into main Oct 8, 2024
18 checks passed
@gustavo-shigueo gustavo-shigueo deleted the fix/serde-json-value-null branch October 24, 2024 11:56
@gustavo-shigueo gustavo-shigueo added the bug Something isn't working label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants