Fix: Hyprland/Workspaces' windows disappearing when moving around #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: swap push_back to emplace_back
…ecial qualifier prefix
… taking them from workspaces
Syndelis
force-pushed
the
fix/hyprland-windows-disappearing
branch
from
97f150f to
e845db8
Compare
This reverts commit e14a3b8.
feat: avoid recreating duplicate workspaces
khaneliman
approved these changes
Oct 20, 2023
|
Thanks a lot again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2557
About this PR
This PR fixes an issue that caused windows to disappear. This was caused because, sometimes, Hyprland's IPC decides to report the window-related event (
openwindow,movewindow) before thecreateworkspaceevent. This, in turn, caused Waybar to have nowhere to put the moved/opened window, causing it to be discarted.About the solution
In order to solve this problem, the window creation has been delayed, much akin to how workspaces are created; they are pushed into a vector and are processed during
Workspaces::update(). There will be 3 attempts to create each window, accounting for the possibility that thecreateworkspacemessage got just late enough that it wasn't processed in the sameupdate()call.