Fix: Hyprland/Workspaces workspaces not being created as persistent when they already exist at startup #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2023
Syndelis
changed the title
Syndelis
deleted the
fix/hyprland-persistent-workspaces-disappear-when-empty
branch
zjeffer
reviewed
Oct 24, 2023
Comment on lines
+490
to
+492
| if (workspace_data["persistent"].asBool() and !(*workspace)->is_persistent()) { | ||
| (*workspace)->set_persistent(); | ||
| } |
There was a problem hiding this comment.
You can change these 3 lines to just (*workspace)->set_persistent(workspace_data["persistent"].asBool()), right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2597
About this PR
This PR guarantees persistent workspace rules will be applied even if the workspaces already exists at bar startup.
Previously, persistent workspaces would always be created before regular workspaces. #2578 changed that in order to guarantee workspaces were created with their respective windows.
However, this meant that pre-existing would-be-persistent workspaces were being created by another function, one which did not account for the persistent configuration.
The changes in this PR makes it so that the
Workspaces::create_workspacemethod checks if a workspace with the same name already exists and, if so, sets the workspace as persistent depending on the payload, rather than attempting to create a new one.