Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lookup for Hyprland socket location based on changes from commit a5a6480 of hyprland #3180

Closed
wants to merge 2 commits into from

Conversation

fooeyround
Copy link

@fooeyround fooeyround commented Apr 28, 2024

I tested this locally with Hyprland commit a5a6480.
I am unsure of how you manage breaking changes like this, as this is still only in git and not released.

(Sorry if I used incorrect casing/capitalization)

@sungyoonc
Copy link

hyprwm/Hyprland#5788 (comment)

For those users, I'd recommend checking whether $XDG_RUNTIME_DIR/hypr exists. If yes, use that, if not, use the old /tmp/hypr

I think fallback to /tmp/hypr should be added as there might be cases where you're running the old version of hyprland with the new version of waybar

@niksingh710
Copy link

niksingh710 commented Apr 29, 2024

yep i just updated today to -git branch and ig a fallback should be added also.

@fooeyround
Copy link
Author

Yeah, that is a good way to do it. I might be able to add that tonight.

@zjeffer
Copy link
Contributor

zjeffer commented Apr 29, 2024

I didn't see this PR existed until I made mine, but I implemented the fallback to /tmp/hypr/ already, so you don't have to do it @JacktheDevel0per :)

@Alexays
Copy link
Owner

Alexays commented Apr 29, 2024

Closing in favor of #3183

@Alexays Alexays closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants