Fix all warnings and update dependencies #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Downgraded rand again to match rustc's tests, I didn't see that it was copied from there. Also ran cargo tests in all directories where I could find any and fixed issues with proptest 0.10 changes. There's one test failure in f32_quickcheck but that seems unrelated to the changeset here. |
|
Hi! Thank you for this PR. I'm now helping to maintain the crate until the original author is able to resume work. I appreciate your care with keeping fidelity to the original state of the crate. I've merged this and published to crates.io as |
Closed
Alexhuszagh
pushed a commit
that referenced
this pull request
Apr 19, 2021
Fix all warnings and update dependencies
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Jun 19, 2021
backport Alexhuszagh/rust-lexical#56 ok tb@ jasper@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
cargo testandcargo benchto check that everything still compiles, which it does. However I'm not sure especially regarding the rand dependency.This fixes #55 by using
<Limb as Integer>::BITSto avoid conflicts with the latest nightly and also fixes all other warnings due to unused documentation by moving them inside the macro.