Use fully-qualified syntax for ::BITS
and prep for stdlib stabilization
#57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit only replaces each unqualified use of
$type::BITS
with<$type as crate::util::Integer>::BITS as usize
, and marks theInteger::BITS
constant as au32
.This change allows
core
to stabilize theBITS
constant on the integer primitives.Once
core
stabilizes the constant, you can replace the definition frommem::size_of::<$t>() * 8
to<$t>::BITS
. You will also be able to strip the< as crate::util::Integer>::
qualification syntax from most of the use sites, which use known typenames rather than trait-only generics.In a followup PR, if you assent, I will replace much of the
Integer
trait with myfunty
crate so that you do not need to have the maintenance burden of integer typing going forward.