Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.0: Fix Xcode 8 GM compatibility #201

Merged
merged 1 commit into from
Sep 9, 2016
Merged

Swift 3.0: Fix Xcode 8 GM compatibility #201

merged 1 commit into from
Sep 9, 2016

Conversation

ikesyo
Copy link
Collaborator

@ikesyo ikesyo commented Sep 7, 2016

No description provided.

@mxcl
Copy link
Contributor

mxcl commented Sep 8, 2016

We want to keep the single #if block, this was a design decision in previous PRs, could you amend the patch conforming to the previous style? Thanks.

@ikesyo
Copy link
Collaborator Author

ikesyo commented Sep 8, 2016

Rebased

@mxcl mxcl merged this pull request into swift-3.0 Sep 9, 2016
@mxcl
Copy link
Contributor

mxcl commented Sep 9, 2016

Many thanks.

@AliSoftware
Copy link
Owner

👍 thanks for the taking care of this fix 👌

@ikesyo ikesyo deleted the xcode8-gm branch September 9, 2016 17:29
@AliSoftware
Copy link
Owner

5.2.1 is out, with this fix included 🎉

  • I cherry-picked this fix from swift3 in master, so that people using CocoaPods can still point to pod 'OHHTTPStubs, '~> 5.2' and get that change too if they're using Xcode 8 GM
  • I rebased the swift3 branch on top of master so that the only commit making swift3 differ from master is still SWIFT_VERSION=3.0 only, as this branch's only purpose is for Carthage users only

For Swift 2.2 / 2.3 users, this 5.2.1 doesn't have much change compared to 5.2.0 (except README & docs typos) but I prefer keeping all my versions in sync to avoid confusions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants