[WIP] Swift 3.0 #94

marcelofabri · 2016-09-07T22:03:27Z

This adds support to Swift 3.0. It's still WIP:

Update core
Update core tests
Update RAC
Update RAC tests
Update podspec
Point OHHTTPStubs to Swift 3.0: Fix Xcode 8 GM compatibility AliSoftware/OHHTTPStubs#201 or wait until that is merged
Update tests to run on iOS 10: they seem to be failing on the Simulator with the same issue mentioned here: https://forums.developer.apple.com/thread/51071 and http://stackoverflow.com/questions/38456471/secitemadd-always-returns-error-34018-in-xcode-8-beta-4-in-ios-10-simulator I think this should be done on a later PR, since it'll probably need to create an app target so the unit tests could be run on a host app (with an Entitlements file)
Lock dependencies to releases (some of them are referring to branches)

marcelofabri · 2016-09-07T22:05:25Z

Heimdallr/Core/URLRequestExtensions.swift

-                let substring = string.substringWithRange(range)
-
-                escaped += substring.stringByAddingPercentEncodingWithAllowedCharacters(allowedCharacterSet) ?? substring
+        var allowedCharacterSet = CharacterSet.urlQueryAllowed


I've updated this from Alamofire code. It seems that they are dropping iOS 8.x on the new release. Maybe we should do the same? (If not, this needs to be reverted and converted to Swift 3.0)

From my point of view it is ok to drop iOS 8 support. If someone needs it, we are open for a Pull Request :)

marcelofabri · 2016-09-07T22:09:29Z

Also, I chose to not mark the classes as open as the converter suggested, but that may be discussible

marcelofabri · 2016-09-07T22:15:10Z

I think Circle hasn't update to the GM yet

marcelofabri · 2016-09-19T19:04:58Z

Cartfile.resolved

 github "jspahrsummers/xcconfigs" "0.9"
-github "ReactiveCocoa/ReactiveCocoa" "v4.2.2"
+github "ReactiveCocoa/ReactiveCocoa" "v4.0.0-alpha.3"


for some reason, this was changed when I updated Nimble

¯_(ツ)_/¯

marcelofabri · 2016-09-19T19:16:21Z

So, the macOS and iOS builds are passing, but the Reactive Cocoa isn't. From what I've seen, 4.x won't support Swift 3, so we'd need to wait for 5.0. I have no idea if master is currently stable or not as I have little familiarity with RC.

Thoughts?

SusannProszak · 2016-09-20T16:22:12Z

hello @marcelofabri
thanks for your pr. 👍
we prefer to wait until ReactiveCocoa releases swift 3.0 support. Until then I would leave the pr in [WIP].

tesths · 2016-09-24T15:10:09Z

So, is there any plan to migrate Heimdallr to Swift 3.0?
I already use Xcode 8😔Recently I want to update my project to support swift 3.0.

marcelofabri · 2016-09-26T10:31:56Z

Should we use https://github.com/ReactiveCocoa/ReactiveSwift instead of RAC 4? If so, there's already a 1.0.0-alpha.1 release we can use.

marcelofabri · 2016-10-05T12:56:15Z

I've updated the dependencies now that Nimble and Quick have stable versions and also updated the code to use ReactiveSwift instead of ReactiveCocoa.

However, I had to comment all the Objective-C compatibility section from Heimdallr+ReactiveCocoa because I didn't know how to migrate that.

Kalzem · 2016-10-12T16:39:17Z

Excuse me, I don't have much details into the project but as a user of Heimdallr, I would like to understand why is there - historically - blocking dependencies still here?
There was already a problem with the JSON parser before (Argo).
And now RAC.

Or is it that we can DL this branch, exclude RAC, and get things working?

marcelofabri · 2016-10-12T21:35:46Z

@BabyAzerty If you use CocoaPods, you can use my fork without the RAC subspec (it's optional), so you can migrate your project to Swift 3.0 while waiting this PR to be merged. Just change your Podfile:

pod 'Heimdallr', git: 'https://github.com/marcelofabri/Heimdallr.swift.git', branch: 'swift-3.0'

While I can't speak for the maintainers, I think it'd be useful to make the RAC extension another repository to make it easier to manage, but I don't know how complex that would make things.

bckr · 2016-10-26T09:23:46Z

I've updated the dependencies now that Nimble and Quick have stable versions and also updated the code to use ReactiveSwift instead of ReactiveCocoa.

@marcelofabri Thank you so much for this and sorry for our late response here. We've been a bit busy the last couple of weeks but I would like to rekindle the discussion here again.

However, I had to comment all the Objective-C compatibility section from Heimdallr+ReactiveCocoa because I didn't know how to migrate that.

I think if we want to have full compatibility with Objc and Swift we'll require both ReactiveCocoa and the ReactiveObjCBridge now because the repository will be split up into multiple smaller ones for the upcoming release that brings Swift 3 compatibility.

While I can't speak for the maintainers, I think it'd be useful to make the RAC extension another repository to make it easier to manage, but I don't know how complex that would make things.

I like that idea! I believe it would make the project way easier to maintain. Since we are also internally moving away from heavy RAC usage in our project, it might be the right direction for Heimdallr as well. The reactive extensions can still live in a separate repository. I'll discuss it internally and comment here if we have made a final decision. Otherwise the Swift 3 migration would be blocked until we get a stable RAC 5.0 release.

bckr · 2016-11-02T10:15:15Z

We decided that we are fine with splitting up the repository and removing RAC as a dependency for this repository.

@marcelofabri Do you want to tackle that? I think you already provide a working Swift 3 fork without the RAC subspec? We'll create a second repository for the reactive extensions when we have a stable RAC release. Let me know if I can help you out in any way 😊

marcelofabri · 2016-11-02T16:28:39Z

@bckr I'm currently traveling, so it's unlikely that I'm able to work on this for the next ~2 weeks. The fork currently have a RAC subspec, but it's just not working 100%.

I've allowed edits from maintainers, so feel free to start from my fork if you wanna handle this.

bckr · 2016-11-02T16:34:39Z

@marcelofabri Will do! Thanks!

# Conflicts: # Heimdallr/Core/Heimdallr.swift # Heimdallr/Core/OAuthAccessTokenDefaultParser.swift # Heimdallr/Core/OAuthAccessTokenParser.swift # HeimdallrTests/Core/HeimdallrSpec.swift

Ingibjorg · 2016-11-30T10:52:09Z

Hi all,
what is the ETD on this update? Heimdallr is the only library that prevents me from being able to update my project from Swift 2.3 to Swift 3.0. Xcode 8.2 will be the last release that will support Swift 2.3 so we should migrate quickly to Swift 3.0.

jPaolantonio · 2017-01-11T21:35:21Z

Is there anything I can do to help the Swift 3 migration?

marcelofabri reviewed Sep 7, 2016
View reviewed changes

marcelofabri commented Sep 19, 2016

View reviewed changes

marcelofabri mentioned this pull request Sep 19, 2016

Update to Xcode 8.0 / Swift 2.3 #95

Merged

dccarmo mentioned this pull request Sep 19, 2016

Can't build with Carthage #97

Closed

SusannProszak mentioned this pull request Sep 21, 2016

Update Result dependency to version 3.0.0 #96

Open

pk1 mentioned this pull request Sep 21, 2016

Migrate to Swift 3.0 #87

Open

marcelofabri added 8 commits October 5, 2016 09:20

Updating dependencies

218910d

Updating core and tests to Swift 3

a44bc03

Renaming extensions

6130ca3

Updating project to set SWIFT_VERSION on macOS

b9e8502

Updating dependencies

8e8976b

Updating dependencies

61f596d

Making Heimdallr open

b9b4367

Using ReactiveSwift

98b08e6

marcelofabri added 2 commits October 5, 2016 10:04

Updating ReactiveHeimdallr macOS target to Swift 3

e04d514

Updating podspec

41099fe

Update dependencies

af40d89

Stengo added 2 commits November 10, 2016 17:10

Restore objective c compatibility

7a36342

Merge branch 'master' into swift-3.0

9b2ab3f

# Conflicts: # Heimdallr/Core/Heimdallr.swift # Heimdallr/Core/OAuthAccessTokenDefaultParser.swift # Heimdallr/Core/OAuthAccessTokenParser.swift # HeimdallrTests/Core/HeimdallrSpec.swift

Stengo added 2 commits January 12, 2017 10:24

Update dependencies

0c883b5

Fix ReactiveCocoa extension

2131400

ugoArangino merged commit 5fc552d into trivago:master Feb 6, 2017

marcelofabri deleted the swift-3.0 branch September 3, 2019 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Swift 3.0 #94

[WIP] Swift 3.0 #94

marcelofabri commented Sep 7, 2016 •

edited by Stengo

Loading

marcelofabri Sep 7, 2016

hffmnn Sep 20, 2016

marcelofabri commented Sep 7, 2016

marcelofabri commented Sep 7, 2016

marcelofabri Sep 19, 2016

marcelofabri commented Sep 19, 2016 •

edited

Loading

SusannProszak commented Sep 20, 2016

tesths commented Sep 24, 2016

marcelofabri commented Sep 26, 2016

marcelofabri commented Oct 5, 2016

Kalzem commented Oct 12, 2016

marcelofabri commented Oct 12, 2016

bckr commented Oct 26, 2016 •

edited

Loading

bckr commented Nov 2, 2016

marcelofabri commented Nov 2, 2016

bckr commented Nov 2, 2016

Ingibjorg commented Nov 30, 2016

jPaolantonio commented Jan 11, 2017

[WIP] Swift 3.0 #94

[WIP] Swift 3.0 #94

Conversation

marcelofabri commented Sep 7, 2016 • edited by Stengo Loading

marcelofabri Sep 7, 2016

Choose a reason for hiding this comment

hffmnn Sep 20, 2016

Choose a reason for hiding this comment

marcelofabri commented Sep 7, 2016

marcelofabri commented Sep 7, 2016

marcelofabri Sep 19, 2016

Choose a reason for hiding this comment

marcelofabri commented Sep 19, 2016 • edited Loading

SusannProszak commented Sep 20, 2016

tesths commented Sep 24, 2016

marcelofabri commented Sep 26, 2016

marcelofabri commented Oct 5, 2016

Kalzem commented Oct 12, 2016

marcelofabri commented Oct 12, 2016

bckr commented Oct 26, 2016 • edited Loading

bckr commented Nov 2, 2016

marcelofabri commented Nov 2, 2016

bckr commented Nov 2, 2016

Ingibjorg commented Nov 30, 2016

jPaolantonio commented Jan 11, 2017

marcelofabri commented Sep 7, 2016 •

edited by Stengo

Loading

marcelofabri commented Sep 19, 2016 •

edited

Loading

bckr commented Oct 26, 2016 •

edited

Loading