Update to Xcode 8.0 / Swift 2.3 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into swift-2.3 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
@SusannProszak instead of disabling tests, what do you think about forcing them to run on iOS 9? My PR changed this (#94). |
hffmnn
reviewed
Sep 20, 2016
| describe("func storeAccessToken(accessToken: OAuthAccessToken?)") { | ||
|
|
||
| // Since there is a bug with writing to the keychain within the iOS10 simulator we had to | ||
| // disbale some test until the bug is fixed by apple. Radar: https://openradar.appspot.com/27844971 |
|
Regarding the Keychain bug: One more thing we might think of is adding a test application and move the failing test into the tests of the test application (kind of meta). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
Macis nowmacOSRegarding the failing tests: there is currently a bug with the latest iOS 10 simulators and the keychain. We agreed on disable the tests until the bug is fixed by apple.