Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant columns in session.trials #771

Closed
alexpiet opened this issue Jun 24, 2019 · 2 comments
Closed

redundant columns in session.trials #771

alexpiet opened this issue Jun 24, 2019 · 2 comments
Assignees
Labels
behavior braintv relates to Insitute BrainTV program task

Comments

@alexpiet
Copy link
Contributor

@nicain There is redundant information in the session.trials table

session.trials.go is True if it a go true
session.trials.catch is True if it is a catch trial (exact opposite of session.trials.go)
session.trials.sham_change is True if it is a catch trial (exactly redundant of session.trials.catch)

I can think of why you might want to have both 'go' and 'catch' as one-hot encoding, but I can't think of a reason why you might want both 'catch' and 'sham_change.'

I am using the LimsApi on the internal branch of the SDK

@nicain
Copy link
Contributor

nicain commented Jun 24, 2019

@dougollerenshaw can you confirm this? If so, I will remove sham_change as a column.

@dougollerenshaw
Copy link
Contributor

dougollerenshaw commented Jun 24, 2019 via email

@nicain nicain self-assigned this Jun 24, 2019
@nicain nicain added the task label Jun 24, 2019
@wbwakeman wbwakeman added behavior braintv relates to Insitute BrainTV program labels Jan 18, 2020
@wbwakeman wbwakeman added this to the Pika 2020-03-11 milestone Feb 27, 2020
@kschelonka kschelonka self-assigned this Feb 27, 2020
kschelonka added a commit that referenced this issue Mar 5, 2020
…undant-trial-col

GH 771: Remove redundant 'sham_change' column from trials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior braintv relates to Insitute BrainTV program task
Projects
None yet
Development

No branches or pull requests

6 participants