GH 771: Remove redundant 'sham_change' column from trials #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
requested review from
NileGraddis,
njmei and
sgratiy
as code owners
|
I think it would be good to note in #771 which exact function(s) use(s) the "sham_change" column. |
Ok, I can do that. It's only functions that go into producing the actual |
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to #771. I checked for the use of "sham_change" in the repo -- I found some uses internally in the function that produces the trial dataframe, but no downstream functions in the AllenSDK.
Functions using the column:
all in
allensdk.brain_observatory.behavior.trials_processing(outside of tests)trial_data_from_log(used only byget_trials, could be made private)get_change_time(function defined in local scope ofget_trials)get_change_time_frame_response_latency(used only byget_trials_v0, which seems deprecated/unused? Could be made private/removed.)