Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1289: Partial fix for data access #1347

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

kschelonka
Copy link
Contributor

There is currently a TODO to unit-test this function, which has multiple undocumented dependencies. I think that's beyond the scope of this fix, but I was able to confirm that this works by getting the stimulus presentations via the Session object for a previously failed ID.

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #1347 into rc/1.5.0 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc/1.5.0    #1347   +/-   ##
=========================================
  Coverage     34.35%   34.35%           
=========================================
  Files           340      340           
  Lines         33004    33004           
=========================================
  Hits          11340    11340           
  Misses        21664    21664
Impacted Files Coverage Δ
.../brain_observatory/behavior/stimulus_processing.py 27.04% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bdbb6...bc8fd2d. Read the comment docs.

Copy link
Contributor

@njmei njmei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, I would double check that the start frames always end with *.0. There should be another issue created to also address this problem upstream since start_frame and end_frame shouldn't even be float in the first place...

@kschelonka
Copy link
Contributor Author

kschelonka commented Feb 5, 2020

Thanks Nick, I've added an issue to the visual behavior epic to check on this data source. This function and it's dependencies are unfortunately undocumented and untested. I'd like to dig into the requirements in the future.

@kschelonka kschelonka merged commit ec75e61 into rc/1.5.0 Feb 5, 2020
@kschelonka kschelonka deleted the GH-1289/behavior-analysis-table-error branch February 5, 2020 23:18
kschelonka added a commit that referenced this pull request Mar 13, 2020
GH 1357: Project caches should not accept arbitrary kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants