Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket/2453/bad/mouse #2455

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Ticket/2453/bad/mouse #2455

merged 5 commits into from
Jun 2, 2022

Conversation

danielsf
Copy link
Contributor

@danielsf danielsf commented Jun 2, 2022

This PR addresses

#2453 by making our _filter_on_death_date code treat death_on = None as "the mouse is still alive" (though that mouse was dead and we have updated LIMS accordingly)

#2452 by adding a failed_ecephys_session_id_list field to the metadata writer schema. These sessions will be used when constructing each mouse's history with our apparatus, then dropped at the moment of output.

@danielsf
Copy link
Contributor Author

danielsf commented Jun 2, 2022

By way of validating that this actually addresses #2452, I re-generated the metadata tables using this branch. The passed sessions for the mice the Corbett called out are all marked as session_number = 2 now

>>> import pandas as pd
df>>> df=pd.read_csv('ecephys_sessions.csv')
>>> df.loc[df.mouse_id==524760, 'session_number']
1    2
Name: session_number, dtype: int64
>>> df.loc[df.mouse_id==546512, 'session_number']
48    2
Name: session_number, dtype: int64
>>> df.loc[df.mouse_id==5484865, 'session_number']
Series([], Name: session_number, dtype: int64)
>>> df.loc[df.mouse_id==548465, 'session_number']
54    2
Name: session_number, dtype: int64

Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

this will allow us to properly reconstruct the mouse's history
as it passes through our apparatus
@danielsf danielsf force-pushed the ticket/2453/bad/mouse branch from b1a46d2 to 685e6e9 Compare June 2, 2022 20:42
@danielsf danielsf merged commit 0bcf605 into vbn_2022_dev Jun 2, 2022
@danielsf danielsf deleted the ticket/2453/bad/mouse branch June 8, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants