DAP_UpdateChanAmpAssignPanel: Don't use PGC_SetAndActivateControl for control setting #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
added
the
PR:NeedsBackport
|
This was changed to get rid of directly using the GUI operations. The CAA feedback was circumvented by working on a copy of the CAA wave. Though it looks like there are more dependencies. |
|
… control setting This reverts commit c17cefc (DAP: Use PGC_SetAndActivateControl in DAP_UpdateChanAmpAssignPanel, 2023-07-24). The reason this does not work is that using PGC calls also the GUI control procedure. But we don't want to call the GUI procedure here as we are syncing from CAA wave to the GUI. Found as setting pressure devices doesn't work anymore. The hardware pressure controls and the associations controls share the same GUI control procedures DAP_SetVarProc_CAA and DAP_PopMenuProc_CAA and thus using PGC on associations control also triggers a pressure control update.
t-b
force-pushed
the
bugfix/1866-pressure-controls
branch
from
756188e
to
44b4441
Compare
t-b
added
PR:NeedsForwardPort
|
@timjarsky Ready! |
timjarsky
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c17cefc (DAP: Use PGC_SetAndActivateControl in DAP_UpdateChanAmpAssignPanel, 2023-07-24).
The reason this does not work is that using PGC calls also the GUI control procedure. But we don't want to call the GUI procedure here as we are syncing from CAA wave to the GUI.
Found as setting pressure devices doesn't work anymore. The hardware pressure controls and the associations controls share the same GUI control procedures DAP_SetVarProc_CAA and DAP_PopMenuProc_CAA and thus using PGC on associations control also triggers a pressure control update.
@MichaelHuth The reverted commit introduced in #1804 broke the pressure device selection. Do you remember why the commit was required?
runwithOpts(testsuite = "UTF_ConfigurationHardware.ipf")passes in this branch locally as well.Close #1868