Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAP_UpdateChanAmpAssignPanel: Don't use PGC_SetAndActivateControl for control setting #1866

Merged
merged 2 commits into from
Sep 7, 2023
Merged

DAP_UpdateChanAmpAssignPanel: Don't use PGC_SetAndActivateControl for control setting #1866

merged 2 commits into from
Sep 7, 2023

Commits on Sep 5, 2023

  1. DAP_UpdateChanAmpAssignPanel: Don't use PGC_SetAndActivateControl for… 

    … control setting

This reverts commit c17cefc (DAP: Use PGC_SetAndActivateControl in DAP_UpdateChanAmpAssignPanel, 2023-07-24).

The reason this does not work is that using PGC calls also the GUI control
procedure. But we don't want to call the GUI procedure here as we are
syncing from CAA wave to the GUI.

Found as setting pressure devices doesn't work anymore. The hardware
pressure controls and the associations controls share the same GUI control
procedures DAP_SetVarProc_CAA and DAP_PopMenuProc_CAA and thus using PGC
on associations control also triggers a pressure control update.
    @t-b
    t-b committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3dfe7a8 View commit details
    Browse the repository at this point in the history

  2. DAP_UpdateChanAmpAssignPanel: Add comment

    @t-b
    t-b committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    44b4441 View commit details
    Browse the repository at this point in the history