Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMALLFIX] Put the lineage master and worker behind the flag #1814

Merged
merged 3 commits into from
Oct 19, 2015
Merged

[SMALLFIX] Put the lineage master and worker behind the flag #1814

merged 3 commits into from
Oct 19, 2015

Conversation

yupeng9
Copy link
Contributor

@yupeng9 yupeng9 commented Oct 16, 2015

No description provided.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/6009/
Test PASSed.

calvinjia
calvinjia reviewed Oct 17, 2015
View reviewed changes
servers/src/main/java/tachyon/master/TachyonMaster.java
@@ -170,7 +170,10 @@ protected TachyonMaster() {
mBlockMaster = new BlockMaster(mBlockMasterJournal);
mFileSystemMaster = new FileSystemMaster(mBlockMaster, mFileSystemMasterJournal);
mRawTableMaster = new RawTableMaster(mFileSystemMaster, mRawTableMasterJournal);
mLineageMaster = new LineageMaster(mFileSystemMaster, mLineageMasterJournal);
boolean enableLineage = MasterContext.getConf().getBoolean(Constants.USER_LINEAGE_ENABLED);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lineageEnabled? (Applies to the worker part as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/6038/
Test PASSed.

@calvinjia
Copy link
Contributor

LGTM

calvinjia added a commit that referenced this pull request Oct 19, 2015
@calvinjia
Merge pull request #1814 from yupeng9/lineage
640c814 
[SMALLFIX] Put the lineage master and worker behind the flag
@calvinjia calvinjia merged commit 640c814 into Alluxio:master Oct 19, 2015
@calvinjia
Copy link
Contributor

@yupeng9 Do you mind changing the variable to no longer be a user variable? Since it seems like we do a lot of logic in the servers based on the flag.

@yupeng9
Copy link
Contributor Author

yupeng9 commented Oct 20, 2015

@calvinjia, I set it to be a user variable because it's a feature flag up to the user to turn on/off. But I'm open to other suggestions. What kind of variable that you think is better?

@Xenorith Xenorith mentioned this pull request Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yupeng9 @AmplabJenkins @calvinjia