-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI tools for debugging and analyzing caching issues #18151
Conversation
dora/core/server/master/src/main/java/alluxio/master/scheduler/JournaledJobMetaStore.java
Outdated
Show resolved
Hide resolved
dora/integration/fuse/src/test/java/alluxio/fuse/auth/AbstractAuthPolicyTest.java
Outdated
Show resolved
Hide resolved
@@ -12,37 +12,40 @@ | |||
package fs | |||
|
|||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think golang has strict lint rules... your code won't compile cc @Xenorith
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rule isn't enforced but you could run this command to recursively format the go files: https://golang.cafe/blog/how-to-run-gofmt-recursively.html
i will likely iterate on these new commands and add docs similar to what was done in #1814 so i am not too concerned about doing the cleanup now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix lint before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking comments but if not addressed now, i will need to address them later
alluxio-bot, merge this please |
Add the following CLI tools for debugging and analyzing caching issues: