Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI tools for debugging and analyzing caching issues #18151

Merged
merged 16 commits into from
Sep 17, 2023

Conversation

JiamingMai
Copy link
Contributor

Add the following CLI tools for debugging and analyzing caching issues:

  1. checkCaching. Checks if files under a path have been cached in alluxio.
  2. location. Displays the list of hosts storing the specified file.
  3. consistentHash. This command is for checking whether the consistent hash ring is changed or not.

@JiamingMai JiamingMai self-assigned this Sep 14, 2023
@JiamingMai JiamingMai added the type-ease-of-use This issue is about of how to improve the ease of use of Alluxio product label Sep 14, 2023
@@ -12,37 +12,40 @@
package fs

import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think golang has strict lint rules... your code won't compile cc @Xenorith

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rule isn't enforced but you could run this command to recursively format the go files: https://golang.cafe/blog/how-to-run-gofmt-recursively.html

i will likely iterate on these new commands and add docs similar to what was done in #1814 so i am not too concerned about doing the cleanup now

Copy link
Contributor

@elega elega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint before merge

Copy link
Contributor

@Xenorith Xenorith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking comments but if not addressed now, i will need to address them later

cli/src/alluxio.org/cli/cmd/fs/checkcaching.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/checkcaching.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/checkcaching.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/checkcaching.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/checkcaching.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/consistanthash.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/consistanthash.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/consistanthash.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/consistanthash.go Outdated Show resolved Hide resolved
cli/src/alluxio.org/cli/cmd/fs/consistanthash.go Outdated Show resolved Hide resolved
@JiamingMai
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 6f35645 into Alluxio:main Sep 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-ease-of-use This issue is about of how to improve the ease of use of Alluxio product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants