Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Websockets): ensure to use the correct client names #12654

Merged
merged 4 commits into from
Apr 11, 2024

updated a unit-test

0969f22
Select commit
Loading
Failed to load commit list.
Merged

fix(Websockets): ensure to use the correct client names #12654

updated a unit-test
0969f22
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 11, 2024 in 1s

89.94% (-0.01%) compared to 8d862b7

View this Pull Request on Codecov

89.94% (-0.01%) compared to 8d862b7

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.94%. Comparing base (8d862b7) to head (0969f22).
Report is 2 commits behind head on main.

Files Patch % Lines
...tend/packages/shared/src/websockets/WSConnector.ts 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12654      +/-   ##
==========================================
- Coverage   89.94%   89.94%   -0.01%     
==========================================
  Files        1291     1291              
  Lines       18414    18418       +4     
  Branches     2241     2241              
==========================================
+ Hits        16563    16566       +3     
- Misses       1592     1593       +1     
  Partials      259      259

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov