Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Separate schemaPointer and uniquePointer better #13538

Merged
merged 19 commits into from
Sep 30, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Sep 13, 2024

Description

This PR is an extension of the work done in PR #13406

  • Adding a prefix 'uniquePointer-' to unique pointers, improving the gap between schemaPointer and uniquePointer.

  • Fixed a bug where adding a reference to a non-existing type caused a console error, AddPropertyMenu.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Sep 13, 2024
@lassopicasso lassopicasso self-assigned this Sep 13, 2024
@lassopicasso lassopicasso added quality/engineering Technical or architectural improvements. For example refactoring or upgrading. and removed area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. labels Sep 13, 2024
@lassopicasso lassopicasso linked an issue Sep 17, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (27cd365) to head (673142a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13538      +/-   ##
==========================================
- Coverage   94.23%   94.21%   -0.02%     
==========================================
  Files        1527     1527              
  Lines       20790    20803      +13     
  Branches     2509     2509              
==========================================
+ Hits        19591    19600       +9     
- Misses        950      954       +4     
  Partials      249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lassopicasso lassopicasso force-pushed the separate-unique-and-schema-pointer-more branch from 793547f to b2d8759 Compare September 17, 2024 08:15
@lassopicasso lassopicasso reopened this Sep 17, 2024
@lassopicasso lassopicasso changed the title Separate schemaPointer and uniquePointer better in data model chore: Separate schemaPointer and uniquePointer better in data model Sep 17, 2024
@lassopicasso lassopicasso changed the title chore: Separate schemaPointer and uniquePointer better in data model chore: Separate schemaPointer and uniquePointer better Sep 18, 2024
@lassopicasso lassopicasso marked this pull request as ready for review September 18, 2024 10:30
@lassopicasso lassopicasso removed their assignment Sep 19, 2024
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Bug not in production:

  • Moving a selected property twice errors
    • Moving nonselected properties seems to not fail
    • Also seems to only happen when moving out of an object reference, never from top level
    • Property also loses highlight when moving into an object reference, but is still editable
schemapointer-bug.mp4

@Jondyr Jondyr assigned lassopicasso and unassigned Jondyr Sep 23, 2024
@TomasEng
Copy link
Contributor

Moving a selected property twice errors

I tried to do exactly as in the video, but I was not able to reproduce this. Maybe it was fixed by #13635? Could you test again, @Jondyr?

Property also loses highlight when moving into an object reference, but is still editable

This seems to be present in production as well. I suggest we create a separate issue for it.

@Jondyr
Copy link
Member

Jondyr commented Sep 26, 2024

@TomasEng

I tried to do exactly as in the video, but I was not able to reproduce this. Maybe it was fixed by #13635? Could you test again, @Jondyr?

I managed to replicate it locally on b240351, clip recreating this from an empty datamodel:

20240926-1111-23.9104554.mp4

@TomasEng
Copy link
Contributor

Thank you for retesting, @Jondyr. Now I managed to replicate it. I'll look into it.

@TomasEng
Copy link
Contributor

Fixed the bug. This can now be retested. Not sure why Codecov fails on project coverage, as we've added more code with 100% diff hit.

@TomasEng TomasEng requested a review from Jondyr September 27, 2024 07:44
@TomasEng TomasEng assigned Jondyr and unassigned TomasEng Sep 27, 2024
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested without any errors ✅ The changes also keeps the selection indication when moving the nodes, well done 👏

@Jondyr Jondyr removed their assignment Sep 30, 2024
@Jondyr Jondyr merged commit ab7fea3 into main Sep 30, 2024
9 of 10 checks passed
@Jondyr Jondyr deleted the separate-unique-and-schema-pointer-more branch September 30, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. area/process Area: Related to app process (e.g. signing, receipt, fill inn, payment, etc). area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. quality/engineering Technical or architectural improvements. For example refactoring or upgrading. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Opening a node that is an object type with multiple usages, will open all
3 participants