-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Separate schemaPointer and uniquePointer better #13538
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13538 +/- ##
==========================================
- Coverage 94.23% 94.21% -0.02%
==========================================
Files 1527 1527
Lines 20790 20803 +13
Branches 2509 2509
==========================================
+ Hits 19591 19600 +9
- Misses 950 954 +4
Partials 249 249 ☔ View full report in Codecov by Sentry. |
793547f
to
b2d8759
Compare
…error will occur in log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
Bug not in production:
- Moving a selected property twice errors
- Moving nonselected properties seems to not fail
- Also seems to only happen when moving out of an object reference, never from top level
- Property also loses highlight when moving into an object reference, but is still editable
schemapointer-bug.mp4
…chema-pointer-more
I tried to do exactly as in the video, but I was not able to reproduce this. Maybe it was fixed by #13635? Could you test again, @Jondyr?
This seems to be present in production as well. I suggest we create a separate issue for it. |
Thank you for retesting, @Jondyr. Now I managed to replicate it. I'll look into it. |
Fixed the bug. This can now be retested. Not sure why Codecov fails on project coverage, as we've added more code with 100% diff hit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested without any errors ✅ The changes also keeps the selection indication when moving the nodes, well done 👏
Description
This PR is an extension of the work done in PR #13406
Adding a prefix 'uniquePointer-' to unique pointers, improving the gap between
schemaPointer
anduniquePointer
.Fixed a bug where adding a reference to a non-existing type caused a console error,
AddPropertyMenu
.Related Issue(s)
Verification
Documentation