-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Generate unique pointer correctly #13635
Conversation
202ede1
to
f394132
Compare
f394132
to
8c678bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13635 +/- ##
=======================================
Coverage 95.23% 95.24%
=======================================
Files 1502 1502
Lines 20567 20582 +15
Branches 2492 2493 +1
=======================================
+ Hits 19588 19603 +15
Misses 869 869
Partials 110 110 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 🚀
tested on localhost, tested OK. |
Description
The newly introduced
uniquePointer
concept, which generates a unique ID for each node in the tree view, does not take combinations into account, which leads to errors. This pull request adds anextractCategoryFromPointer
function that basically returns the part of the pointer that comes before the name (properties
,anyOf
etc.). This function is then used to generate the unique pointer correctly.Steps to reproduce the bug
Spiller.inn.2024-09-25.131013.mp4
Verification