Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-editor): remove custom component from toolbar list #14362

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Jan 6, 2025

Description

See #14361 for reasoning.
This PR only removes the component from the component toolbar, and does not remove the json schemas or any of the config setups. Layouts with this component in use will still be able to configure it.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Jan 6, 2025
@nkylstad nkylstad changed the title remove custom component from toolbar list chore(ui-editor): remove custom component from toolbar list Jan 6, 2025
@nkylstad
Copy link
Member Author

nkylstad commented Jan 6, 2025

Testing comment - this can probably be tested locally rather than deployed to dev, as it is a tiny frontend change 😊

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (a712b7d) to head (149ffb5).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14362   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files        1860     1860           
  Lines       24106    24106           
  Branches     2783     2783           
=======================================
  Hits        23031    23031           
  Misses        817      817           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mlqn mlqn linked an issue Jan 8, 2025 that may be closed by this pull request
1 task
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK locally! 🚀

@mlqn mlqn merged commit 7b805ee into main Jan 8, 2025
10 checks passed
@mlqn mlqn deleted the chore/14361-hide-custom-component-in-toolbar branch January 8, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Custom component type from component list
3 participants