Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-editor): remove custom component from toolbar list #14362

Merged
merged 2 commits into from
Jan 8, 2025
Merged

chore(ui-editor): remove custom component from toolbar list #14362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a5378a
remove custom component from toolbar list
nkylstad Jan 6, 2025
149ffb5
exclude Custom component from visibility test
nkylstad Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/packages/ux-editor/src/data/formItemConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,14 @@ describe('formItemConfig', () => {
confOnScreenComponents,
];
const allAvailableComponents = allAvailableLists.flat();
const excludedComponents = [ComponentType.Payment, ComponentType.Subform, ComponentType.Summary2];
const excludedComponents = [
ComponentType.Custom,
ComponentType.Payment,
ComponentType.Subform,
ComponentType.Summary2,
];

/** Test that all components, except Payment, Subform and Summary2 (since behind featureFlag), are available in one of the visible lists */
/** Test that all components, except Custom, Payment, Subform and Summary2 (since behind featureFlag), are available in one of the visible lists */
it.each(
Object.values(ComponentType).filter(
(componentType) => !excludedComponents.includes(componentType),
Expand Down
1 change: 0 additions & 1 deletion frontend/packages/ux-editor/src/data/formItemConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ export const advancedItems: FormItemConfigs[ComponentType][] = [
formItemConfigs[ComponentType.Accordion],
formItemConfigs[ComponentType.AccordionGroup],
formItemConfigs[ComponentType.List],
formItemConfigs[ComponentType.Custom],
formItemConfigs[ComponentType.RepeatingGroup],
formItemConfigs[ComponentType.PaymentDetails],
shouldDisplayFeature(FeatureFlag.Subform) && formItemConfigs[ComponentType.Subform],
Expand Down
Loading