Add todo for #386

Altinn · Jun 5, 2024 · bd59d04 · bd59d04
1 parent 5db8ed8
commit bd59d04
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/Digdir.Domain.Dialogporten.Application/Common/Extensions/ClaimsPrincipalExtensions.cs b/src/Digdir.Domain.Dialogporten.Application/Common/Extensions/ClaimsPrincipalExtensions.cs
@@ -233,6 +233,9 @@ public static (UserIdType, string externalId) GetUserType(this ClaimsPrincipal c
     {
         if (claimsPrincipal.TryGetPid(out var externalId))
         {
+            // ServiceOwnerOnHelfOfPerson does not work atm., since there will be no PID claim on service owner calls
+            // TODO: This needs to be fixed when implementing https://github.com/digdir/dialogporten/issues/386
+            // F.ex. a middleware that runs before UserTypeValidationMiddleware that adds the PID claim
             return (claimsPrincipal.HasScope(ServiceProviderScope)
                 ? UserIdType.ServiceOwnerOnBehalfOfPerson
                 : UserIdType.Person, externalId);